-
Notifications
You must be signed in to change notification settings - Fork 412
Added 'Language Selector' plugin #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The plugin worked successfully on the x64 debug Notepad++, as described by 'How to develop a plugin' guideline.
The plugin worked successfully on the x64 debug notepad++, as described by the 'How to develop a plugin' guidelines.
The plugin worked successfully on the x86 debug notepad++, as described by the 'How to develop a plugin' guidelines.
|
@hassaine-abdellah What about a build for ARM64? Your dlls seems to be rather huge compared to the ones from the CI build. Did you use the debug versions here and was this done intentionally? Json files here should be sorted alphabetically could you please move your new entry accordingly after LanguageHelp. Thanks. |
Rearranged position in the list according to the alphabetical order + added underscore to the folder name so it matches that of the DLL file (became 'Language_selector' instead of 'Language Selector')
Rearranged position in the list according to the alphabetical order + added underscore to the folder name so it matches that of the DLL file (became 'Language_selector' instead of 'Language Selector')
|
@hassaine-abdellah the plugin dll needs to be a the root of the zipfile and not within an folder |
|
Thank you for your feedback @chcg, |
I will correct that now |
@chcg Now they are in the root folder, and the plugin list was updated accordingly (the SHA part) |
|
@hassaine-abdellah Remaining issue for win32: Language Selector You modified 3P plugin instead of your plugin in x86 json. |
|
Ok my mistake, now everything is fine. |
Successful testing: appeared in PA, downloaded, and worked as expected for x64 and x86 bit versions.