Skip to content

Conversation

@hassaine-abdellah
Copy link
Contributor

Successful testing: appeared in PA, downloaded, and worked as expected for x64 and x86 bit versions.

The plugin worked successfully on the x64 debug Notepad++, as described by 'How to develop a plugin' guideline.
The plugin worked successfully on the x64 debug notepad++, as described by the 'How to develop a plugin' guidelines.
The plugin worked successfully on the x86 debug notepad++, as described by the 'How to develop a plugin' guidelines.
@chcg chcg added this to the 1.9.1 milestone Jan 1, 2026
@chcg
Copy link
Contributor

chcg commented Jan 1, 2026

@hassaine-abdellah What about a build for ARM64? Your dlls seems to be rather huge compared to the ones from the CI build. Did you use the debug versions here and was this done intentionally?

Json files here should be sorted alphabetically could you please move your new entry accordingly after LanguageHelp. Thanks.

Rearranged position in the list according to the alphabetical order + added underscore to the folder name so it matches that of the DLL file (became 'Language_selector' instead of 'Language Selector')
Rearranged position in the list according to the alphabetical order + added underscore to the folder name so it matches that of the DLL file (became 'Language_selector' instead of 'Language Selector')
@chcg
Copy link
Contributor

chcg commented Jan 1, 2026

@hassaine-abdellah the plugin dll needs to be a the root of the zipfile and not within an folder

@hassaine-abdellah
Copy link
Contributor Author

Thank you for your feedback @chcg,
As for the huge size, it seems that it comes from me uploading the debug versions generated by vs code on my local machine. This was corrected by uploading files from the CI builds to the plugin assets, for all architectures (including ARM64 that I missed before, which addresses your first question).
All three .json files were updated as well (SHA265 strings and the plugin alphabetical ordering in the list).

@hassaine-abdellah
Copy link
Contributor Author

@hassaine-abdellah the plugin dll needs to be a the root of the zipfile and not within an folder

I will correct that now

@hassaine-abdellah
Copy link
Contributor Author

@hassaine-abdellah the plugin dll needs to be a the root of the zipfile and not within an folder

@chcg Now they are in the root folder, and the plugin list was updated accordingly (the SHA part)

@chcg
Copy link
Contributor

chcg commented Jan 1, 2026

@hassaine-abdellah Remaining issue for win32:

Language Selector
{'category': 'error',
'details': '',
'message': 'Language Selector: Invalid hash. Got '
'cdb445b2f3de150d17ff7219a7dfd6b1d5eb53e8c2baf14d026548e2e9cf1fdf '
'but expected '
'8782bbbf7aa81e6aae882283391d74daadc932b2364c12093aa022028be50481.'}

You modified 3P plugin instead of your plugin in x86 json.

@hassaine-abdellah
Copy link
Contributor Author

Ok my mistake, now everything is fine.

@chcg chcg merged commit bc8322f into notepad-plus-plus:master Jan 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants