feat: version 1.3 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a large internal rework but does not affect overall plugin functionality. Listed below are the key changes. - chore: removed unused includes - chore: removed utilshelper dependency - chore: updated/fixed code formatting - chore: add code comments - feat: added convar for toggling round start hint message - feat: added cookie support - feat: added error message if reloading config failed - fix: resolved empty song names in config printing incorrect message - fix: resolved memory leak caused by using clear() method on stringmap - fix: resolved plugin late load logic for cookies - refactor: plugin now checks convar directly instead of storing convar in variables - refactor: reworked when cookies are stored
Removed duplicate stringmap deletion/creation Change command callback to use replytocommand instead of printtochat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large internal rework but does not affect overall plugin functionality. Listed below are the key changes.
utilshelperdependencyclear()method on stringmap