Rework FindIntro logic per redundant strategy#1
Open
notlesh wants to merge 3 commits intoredundant-introset-propagation-2020-02-19from
Open
Rework FindIntro logic per redundant strategy#1notlesh wants to merge 3 commits intoredundant-introset-propagation-2020-02-19from
notlesh wants to merge 3 commits intoredundant-introset-propagation-2020-02-19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to rework the remaining DHT lookup logic to conform to our "redundant DHT strategy."
One very concrete issue this addresses is that a node handling a relayed lookup will not attempt to return a matching entry if it happens to have it.
TODO: I don't think this handles the case where (1) lookup is relayed and (2) we are the target owner (i.e. we are in the set {A..D})