Fix coding, dependency, and robustness issues in VGDE codebase

[Copilot]

This PR addresses multiple coding quality, performance, and robustness issues identified in the VGDE (Video Game Data Explorer) codebase.

Issues Fixed

1. Redundant Constant Assignments

Removed unnecessary constant assignments that duplicated config values:

# Before: Redundant assignments
MAX_GAME_NAME_LENGTH = config.MAX_GAME_NAME_LENGTH
GAME_NAME_PATTERN = config.GAME_NAME_PATTERN
BASE_URL = config.BASE_URL
GAMES_ENDPOINT = config.GAMES_ENDPOINT

# After: Direct config usage throughout codebase
url = f"{config.BASE_URL}{config.GAMES_ENDPOINT}"

2. Memory Safety in Content Size Checking

Improved _check_content_size() to use content-length header as primary guard, avoiding unnecessary memory consumption:

# Before: Always reads full response content
content = response.content
if len(content) > config.MAX_RESPONSE_SIZE:
    raise ValueError("Response content too large")

# After: Check header first, only read content when necessary
content_length = response.headers.get('content-length')
if content_length and int(content_length) > config.MAX_RESPONSE_SIZE:
    raise ValueError("Response too large")

3. Specific Exception Handling

Replaced broad exception handling with specific exceptions in strip_html_tags():

# Before: Catches everything
except Exception as e:
    logger.warning(f"HTML parsing failed: {e}")

# After: Specific exception types
except (html.parser.HTMLParseError, UnicodeDecodeError, UnicodeError) as e:
    logger.warning(f"HTML parsing failed: {e}")

4. Simplified Logic in fetch_game_data

Removed duplicate validations after _validate_api_response():

# Before: Redundant checks after validation
if not _validate_api_response(data):
    return None
if 'results' in data and isinstance(data['results'], list):  # Duplicate check
    if len(data['results']) > 0:
        return data['results'][0]

# After: Trust validation result
if not _validate_api_response(data):
    return None
results = data['results']  # Safe to access after validation
if len(results) > 0:
    return results[0]

5. Robust Environment Variable Parsing

Enhanced DEVELOPER_MODE parsing to accept comprehensive truthy/falsy values:

# Before: Limited values
DEVELOPER_MODE = os.getenv('DEVELOPER_MODE', 'false').lower() in ('true', '1', 't')

# After: Comprehensive boolean parsing
def _parse_boolean_env(value: str, default: bool = False) -> bool:
    if not value:
        return default
    value = value.lower().strip()
    return value in ('true', '1', 't', 'yes', 'y', 'on', 'enable', 'enabled')

6. Performance Optimization

Pre-compiled regex pattern for game name validation:

# Before: Compiles regex on every validation
if not re.match(config.GAME_NAME_PATTERN, game_name):

# After: Use pre-compiled pattern
GAME_NAME_REGEX = re.compile(config.GAME_NAME_PATTERN)
if not GAME_NAME_REGEX.match(game_name):

Benefits

• Performance: Pre-compiled regex reduces validation overhead
• Memory Efficiency: Content-length checking prevents loading large responses unnecessarily
• Robustness: Specific exception handling improves error precision
• Code Quality: Eliminated redundant code and improved maintainability
• User Experience: More intuitive environment variable parsing (accepts 'yes', 'on', 'false', 'no', etc.)

Backward Compatibility

All changes maintain full backward compatibility. The API surface remains unchanged, and existing functionality is preserved while improving internal implementation quality.

Testing

• ✅ Import functionality verified
• ✅ Game name validation with pre-compiled regex tested
• ✅ HTML stripping with specific exception handling validated
• ✅ Environment variable parsing tested with comprehensive boolean values
• ✅ Command-line interface functionality confirmed
• ✅ Error handling for missing API key verified

This pull request was created as a result of the following prompt from Copilot chat.

Fix coding, dependency, and robustness issues in the VGDE (Video Game Data Explorer) codebase:

1. Remove the unnecessary argparse dependency from requirements.txt, as it is included in the Python standard library.
2. Remove redundant constant assignments (lines 27–32 in vgde.py) and use the config object directly throughout the code.
3. Improve memory safety in _check_content_size by only reading response content when necessary; use content-length header as the primary guard.
4. Replace broad except Exception in strip_html_tags with more specific exception handling for HTML parsing errors and Unicode errors.
5. Simplify logic in the fetch_game_data function by removing duplicate validations and redundant checks after _validate_api_response.
6. Make DEVELOPER_MODE environment parsing more robust by accepting more truthy/falsey values (e.g., 'yes', 'on').
7. Clean up comments and pre-compile the regex for game name pattern.

All changes should be backward compatible and pass existing functionality and error handling tests.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[notrtdsx]

lgtm

[notrtdsx]

@copilot LGTM

[notrtdsx]

@copilot LGTM

[notrtdsx]

@copilot im gonna merge. thanks for helping out