Test nova json schemas #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
nova_json_schemasplugin, and a few tests for that as well.Running the tests with
NOVA_BRANCH=refs/tags/v0.12.1 rebar3 ct(because nova 0.13.x) currently does not work withnova_json_schemasprocudes this output, highlighting the fact that the encoded JSON from therender_error/1function in the plugin will generate an iolist which will then be encoded into json as a list of integers. This will be parsed and decoded bythoasas a list with a string.I would really expect a binary string here, and it is probably a good idea if the encoded json can be parsed correctly by json implementations in other languages.
This is what it looks like in Python, for instance:
This is of course not really mergeable as is, since it has broken tests in it, but I still want to highlight the problem.