Open
Conversation
|
Hello, I tried testing this PR using a local unpacked installation, but it doesn’t seem to work. Have you managed to get it working? Maybe I’m missing something |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the "Use My Current Account" extension from Manifest V2 to Manifest V3, addressing the deprecation of Manifest V2 and ensuring compatibility with modern browser extension standards.
Changes
Manifest Updates (
manifest.json)1.3to1.4manifest_versionfrom2to3browser_actionwithaction(MV3 standard)persistent: trueandscriptsarrayservice_workerarchitecture withservice_worker: "src/background.js"webRequestandwebRequestBlockingpermissionsdeclarativeNetRequestWithHostAccesspermission*://login.microsoftonline.com/*frompermissionsto newhost_permissionsarrayBackground Script Refactor (
src/background.js)Migrated from blocking webRequest to declarativeNetRequest API:
login_hintparameter to/authorizeURLswhrparameter to/saml2and/wsfedURLsModernized code to use Promises/async-await:
getEmail()async function using promise-basedchrome.identity.getProfileUserInfo()Migrated from
chrome.browserActiontochrome.action:Added debug logging system:
DEBUGflag for optional loggingdebugLog(),debugWarn(),debugError()DEBUG = true[UseMyCurrentAccount]for easy identificationTesting
Breaking Changes
None - all functionality remains the same from a user perspective.
Notes