Feature: Add TSV support for easier Excel copy-paste#90
Open
colinbendell wants to merge 1 commit intonowthis:mainfrom
Open
Feature: Add TSV support for easier Excel copy-paste#90colinbendell wants to merge 1 commit intonowthis:mainfrom
colinbendell wants to merge 1 commit intonowthis:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's really janky to build a Sankey from Excel or Google Sheets. Ideally, we could copy-paste from three columns that have the source, target and amount columns.
This PR adds support for tab separated definitions allowing for:
It also supports order confusion in the garget and amount columns:
Additionally, it is much more lenient with the amount allowing for formatted values in a copy-paste to be gracefully handled:
Wages [$1,500] BudgetWages [1 500,00 €] BudgetIn an attempt to make the minimal amount of changes without wholesale refactoring, I've added tests and necessary shims for tests of the regex.
Summary of changes in the PR: