Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I saw comments in the issues that other folks would like colour gradients available, and so would I, so I wrote it.
It's fairly complete, but does have a couple of small notes needed.
Missing is the ability to customize the colour gradient in the flow definition panel - the only way to get them is through the "inherit from" setting "source-target". I have a regex that could be used to detect the new format but no code to implement it.
When drawing very curved flows, the original rendering method (bezier curve with fixed width) looks pleasing, but the new code (filled shape with the same bezier on the top and bottom) does not. Without redrawing with a much more complex algorithm it's just going to not look as good when the curviness is close to maximum.
I've gone through enough testing to ensure it's satisfactory for my needs, but happy for feedback, comments or others testing results.