-
Notifications
You must be signed in to change notification settings - Fork 68
implement github style link headers #225
Conversation
lib/headings.js
Outdated
| Token = state.Token | ||
| savedTokenConstructor = true | ||
| } | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me while doing something else that we can eliminate savedTokenConstructor from this file and just do
if (!Token) {
Token = state.Token
tokenUtil.set(Token)
}|
I LOVE DELETING CODE |
|
|
33, wow. I guess that part of the rendering is well covered 😛 |
|
✨ |
|
niiiiiiiice 👯 |
|
thought -> should the SVG icon be a flag? @revin |
|
@ashleygwilliams probably, you're right. We have a slightly now misnamed option Want an option that disables the link generation altogether? Or an option that enables it, default Also since this is already semver-major, should we rename |
|
Oh wait, did you mean disabling just the icon itself, but still doing the rest of the processing (so we'd still generate the slug and link, but the link would be empty)? |
|
hah yes, the second thing, just the SVG part. something like |
…e/disable headings' generated links' SVG icons
|
I added this as |
056d5a2 to
bb5690b
Compare
fixes #224
to do:
util