Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ notifications:
email: false

node_js:
- 8
- 12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add .nvmrc since we're touching this repo.


before_install:
- sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
Expand Down
8 changes: 6 additions & 2 deletions lib/render.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var emoji = require('markdown-it-emoji')
var expandTabs = require('markdown-it-expand-tabs')
var githubTaskList = require('markdown-it-task-lists')

var cleanup = require('./cleanup')
// var cleanup = require('./cleanup')
var githubLinkify = require('./linkify')

var codeWrap = require('./plugin/code-wrap')
Expand Down Expand Up @@ -48,7 +48,11 @@ if (typeof process.browser === 'undefined') {

// cleanup generated rules in the highlighter registry if they are idle for 2000ms
// they take a tremendous amount of memory if you process many languages in a server type environment.
cleanup(highlighter.registry.grammars)

// this doesn't work with new highlights version,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3.1.4 actually newer than 3.2.0-candidate.1? I think it's not.
Is there any problem keeping the candidate one and keep cleanup code then?

Copy link
Author

@radiantspace radiantspace Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually 3.1.4 is newer:
Screen Shot 2021-01-29 at 12 46 54

The reason for changing to newer version of highlights is to update oniguruma dependency, which is the actual blocker for supporting Node 12.

// so we need to evaluate mem consumption due to this change
// before rolling this change out
// cleanup(highlighter.registry.grammars)
}

var render = module.exports = function (markdown, options) {
Expand Down
2 changes: 1 addition & 1 deletion marky.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"12.0.3","repositoryUrl":"https://github.com/npm/marky-markdown","issuesUrl":"https://github.com/npm/marky-markdown/issues"}
{"version":"13.0.0","repositoryUrl":"https://github.com/npm/marky-markdown","issuesUrl":"https://github.com/npm/marky-markdown/issues"}
198 changes: 103 additions & 95 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading