feat: add missing a11y tests for blog post components#1429
feat: add missing a11y tests for blog post components#1429jonathanyeong wants to merge 2 commits intonpmx-dev:feat/atproto-blog-fefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
| `bluesky-embed-${embeddedId}`, | ||
| () => | ||
| $fetch('/api/atproto/bluesky-oembed', { | ||
| $fetch<BlueskyOEmbedResponse>('/api/atproto/bluesky-oembed', { |
There was a problem hiding this comment.
I'm going to need someone with more nuxt/typescript knowledge to explain why adding this type fixes this issue:
Error: app/components/EmbeddableBlueskyPost.vue(16,5): error TS2321: Excessive stack depth comparing types 'Exclude<R extends "/api/atproto/bluesky-author-profiles" ? { key: "/api/atproto/bluesky-author-profiles"; exact: true; score: []; catchAll: false; } : { key: "/api/atproto/bluesky-author-profiles"; exact: false; score: `${R}/` extends `${infer RouteSeg}/${infer RouteRest}` ? `${RouteSeg}?` extends `${infer RouteSegW...' and '{ score: MaxTuple<((R extends "/api/atproto/bluesky-author-profiles" ? { key: "/api/atproto/bluesky-author-profiles"; exact: true; score: []; catchAll: false; } : { key: "/api/atproto/bluesky-author-profiles"; exact: false; score: `${R}/` extends `${infer RouteSeg}/${infer RouteRest}` ? `${RouteSeg}?` extends `${inf...'.
It was an AI suggestion, and I'm unsure why it works 🤷.
|
I'm seeing these errors when running But I'm not sure why it's failing. I don't think we need to explicitly import |
|
I'm also seeing this issue |
|
Just marking as draft as it's not ready yet and a couple of us are going down the list to see what we can review! |
This PR attempts to address the CI issues in the main blog branch #1094
What
Fixes this CI test failure:
Fixes unused code check: