Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughAdds a TypeScript global augmentation declaring Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
c5c880b to
4454fa9
Compare
danielroe
left a comment
There was a problem hiding this comment.
I'm not sure that the benefit is worth the cost in terms of browser compatibility.
wdyt @ghostdevv?
yeaaa maybe, perhaps there is a minimal ponyfill that achieves the same result 🤔 (because we need something for this, and I'd like to avoid having multiple fns for it over the codebase) |
|
some initial findings, need to step away for a bit so will take another look later |
On the other hand, I don't think a large percentage of npmx audience is using IE or is 11 Chrome versions behind. |
|
regexp.escape won't work on iOS 17 devices. I agree we need a canonical single escape function but it's a tiny one-liner, for our purposes. (https://github.com/lionel-rowe/regexp-escape-polyfill (linked by @ghostdevv above) is just 498 B) |
|
updated to use |
|
For some reason the vercel preview is crashing when you access a package page directly 🤔 it doesn't happen in dev or local preview |
This switches us to use
RegExp.escape()for escaping regex instead of custom regex or none at all.TypeScript hasn't released the ES2025 changes that includes this typedef so I had to add it manually, not sure if there is a better place for the file?