feat(i18n): add vacation message and related content for zh-CN locale#1475
Closed
craigary wants to merge 3 commits intonpmx-dev:mainfrom
Closed
feat(i18n): add vacation message and related content for zh-CN locale#1475craigary wants to merge 3 commits intonpmx-dev:mainfrom
craigary wants to merge 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
It doesn't seem like we're translating for that I guess, thank you for your PR though! (seems like the page will be removed in a week) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for the oversight. I realized my previous PR was missing the vocation reminder section due to my unfamiliarity with the workflow. I have included those missing translations here.
I am so sorry for the extra review work 🥺
This pull request adds a new set of Chinese (zh-CN) translations related to the team's vacation period, including headings, descriptions, and messages for the vacation notice and Discord community closure.
New vacation-related translations:
vacationssection tozh-CN.jsonwith keys and values for vacation titles, descriptions, headings, subtitles, illustrations, Discord closure information, contributor stats, and return messages.Just noticed that the vacations key is being temporarily removed in the compare-translations.ts script, Should I translate the vacations section?