Skip to content

fix: add Luau icons#1492

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
OverHash:feat/luau-icons
Feb 14, 2026
Merged

fix: add Luau icons#1492
ghostdevv merged 1 commit intonpmx-dev:mainfrom
OverHash:feat/luau-icons

Conversation

@OverHash
Copy link
Contributor

Luau icons are missing from the source file viewer.

This is commonly a problem for orgs like @rbxts, which has hundreds of packages with luau source files.

This PR adds the luau icon, using the vscode-icons pack.

Before After
Before: generic file icons for .luau files After: Luau-specific icons in source file viewer

@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 1:00am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 1:00am
npmx-lunaria Ignored Ignored Feb 14, 2026 1:00am

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

This pull request adds a single file extension mapping to the EXTENSION_ICONS constant in app/utils/file-icons.ts. The change introduces support for the 'luau' file extension by mapping it to the 'vscode-icons-file-type-luau' icon. No modifications to logic, error handling, or existing mappings are made.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (3 files):

⚔️ app/utils/file-icons.ts (content)
⚔️ i18n/locales/pl-PL.json (content)
⚔️ lunaria/files/pl-PL.json (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the problem (missing Luau icons), the solution (adding icon mapping), and providing before/after visual evidence.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch feat/luau-icons
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv enabled auto-merge February 14, 2026 01:00
@ghostdevv ghostdevv added this pull request to the merge queue Feb 14, 2026
Merged via the queue into npmx-dev:main with commit ec40fe9 Feb 14, 2026
17 checks passed
@github-actions
Copy link

Thanks for your first contribution, @OverHash! 🙌

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants