Skip to content

fix: dialog title switch with select #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzxming wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: dialog title switch with select #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/components/Package/WeeklyDownloadStats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ const route = useRoute()
const chartModal = useModal('chart-modal')
const hasChartModalTransitioned = shallowRef(false)

const { t } = useI18n()
const modalTitle = computed(() => {
const facet = route.query.facet as string | undefined
if (facet === 'likes') return t('package.trends.items.likes')
if (facet === 'contributors') return t('package.trends.items.contributors')
return t('package.downloads.modal_title')
})

const isChartModalOpen = shallowRef<boolean>(false)

function handleModalClose() {
Expand Down Expand Up @@ -305,7 +313,7 @@ const config = computed(() => {

<PackageChartModal
v-if="isChartModalOpen && hasWeeklyDownloads"
:title="$t('package.downloads.modal_title')"
:title="modalTitle"
@close="handleModalClose"
@transitioned="handleModalTransitioned"
>
Expand Down Expand Up @@ -356,6 +364,7 @@ const config = computed(() => {
padding: 0 !important;
letter-spacing: 0.04rem;
}

.vue-ui-sparkline text {
font-family:
Geist Mono,
Expand Down
Loading