Fix bt rpc gatt deinit #25879

RobertGalatNordic · 2025-11-28T12:48:07Z

No description provided.

…oved fixed memory leak on multiple bt init/disable calls. Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>

NordicBuilder · 2025-11-28T12:53:48Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 0cd7729dafed8671839af522bf77c9d1ca978371

more details

sdk-nrf:

PR head: 0cd7729dafed8671839af522bf77c9d1ca978371
merge base: 9fb34cc3d3cf8afc6d63ce47a09397101858e5e5
target head (main): 2f953501a364ec71d3b1ef6e6fae418d8f3269f7
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (9)

subsys
│  ├── bluetooth
│  │  ├── rpc
│  │  │  ├── common
│  │  │  │  │ bt_rpc_gatt_common.c
│  │  │  ├── host
│  │  │  │  │ bt_rpc_gatt_host.c
tests
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── rpc_gatt_service
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  ├── log_stub.c
│  │  │  │  │  ├── main.c
│  │  │  │  │  ├── nrf_rpc_cbor.h
│  │  │  │  │  │ test_config.h
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 43683a87ea
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:43683a87ea_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 909
❌ Integration tests
- ❌ test-fw-nrfconnect-ble_samples
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-ps-main
- ⚠️ test_ble_nrf_config

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-mcuboot
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

subsys/bluetooth/rpc/common/bt_rpc_gatt_common.c

Damian-Nordic · 2025-11-28T13:53:50Z

tests/subsys/bluetooth/rpc_gatt_service/CMakeLists.txt

+
+FILE(GLOB app_sources src/*.c)
+
+# Remove log_stub.c from glob since we include it explicitly


So we exclude it to include it later? What's the goal?

yes this does not make sense, removed it.

Damian-Nordic · 2025-11-28T13:55:12Z

tests/subsys/bluetooth/rpc_gatt_service/CMakeLists.txt

+# Remove log_stub.c from glob since we include it explicitly
+list(FILTER app_sources EXCLUDE REGEX ".*log_stub\\.c$")
+
+# Add src directory for test_config.h


It's included by an absolute path anyway, so this is not really needed.

the comment was misleeding, but I still need to include the /src dir.

Damian-Nordic · 2025-11-28T13:56:50Z

tests/subsys/bluetooth/rpc_gatt_service/prj.conf

+
+# Minimal BT configuration - just enough to use the real gatt.h header
+# We don't need full BT stack functionality, just the type definitions
+CONFIG_BT=y


gatt.h is in the public include directory, so you don't really need CONFIG_BT to be able to include <zephyr/bluetooth/gatt.h> do you?

that is true, removed unnecessary config

Damian-Nordic · 2025-11-28T13:58:50Z

tests/subsys/bluetooth/rpc_gatt_service/src/main.c

+#include <stddef.h>
+#include <stdint.h>
+
+/* Include the header - it will use our stub zephyr/bluetooth/gatt.h */


There's no stub gatt.h, right?

in deed there is none. it seems like the comment is a leftover from previous iteration of the test implementation. removed it.

Damian-Nordic · 2025-11-28T14:04:35Z

tests/subsys/bluetooth/rpc_gatt_service/src/nrf_rpc_cbor.h

+/* Forward declaration - full definition not needed for unit testing */
+struct nrf_rpc_cbor_ctx;
+
+/* Typedef for compatibility */


Original nRF RPC doesn't use typedef so there's no point in adding it in stub either.

that is true, removed it.

NordicBuilder · 2025-11-28T14:21:13Z

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug_nrf21540ek_multicore[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 784[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 776[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52820dongle/nrf52820]: ROM size increased by 660[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 968[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 988[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 552[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 968[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52820]: ROM size increased by 1000[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52dmouse/nrf52832]: ROM size increased by 516[B] in comparison to the main[29bfe34] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-25879/7)

check if gatt services are correctly clean after remove Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>

bt_rpc: fix issue with cleaning gatt buffer after last service is rem…

722e2dc

…oved fixed memory leak on multiple bt init/disable calls. Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>

RobertGalatNordic requested a review from MarekPorwisz November 28, 2025 12:48

RobertGalatNordic requested review from a team as code owners November 28, 2025 12:48

NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 28, 2025

NordicBuilder requested a review from a team November 28, 2025 12:48

Damian-Nordic reviewed Nov 28, 2025

View reviewed changes

subsys/bluetooth/rpc/common/bt_rpc_gatt_common.c Show resolved Hide resolved

RobertGalatNordic force-pushed the fix_bt_rpc_gatt_deinit branch from 98212f4 to bf9e1c0 Compare November 28, 2025 13:13

RobertGalatNordic requested a review from Damian-Nordic November 28, 2025 13:14

RobertGalatNordic force-pushed the fix_bt_rpc_gatt_deinit branch 3 times, most recently from 7ab29c1 to 81962e6 Compare November 28, 2025 13:29

Damian-Nordic approved these changes Nov 28, 2025

View reviewed changes

Damian-Nordic reviewed Nov 28, 2025

View reviewed changes

RobertGalatNordic force-pushed the fix_bt_rpc_gatt_deinit branch 2 times, most recently from a453ff8 to 0cd7729 Compare November 28, 2025 14:32

bt_rpc: Added unit test to check for gatt service registration cycle

0cd7729

check if gatt services are correctly clean after remove Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>


		FILE(GLOB app_sources src/*.c)

		# Remove log_stub.c from glob since we include it explicitly

Fix bt rpc gatt deinit #25879

Are you sure you want to change the base?

Fix bt rpc gatt deinit #25879

Uh oh!

Conversation

RobertGalatNordic commented Nov 28, 2025

Uh oh!

NordicBuilder commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory footprint analysis revealed the following potential issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NordicBuilder commented Nov 28, 2025 •

edited

Loading

NordicBuilder commented Nov 28, 2025 •

edited

Loading