Fixed passkey deprecation #3466
Conversation
| * pairing, or BT_PASSKEY_RAND to generate a random passkey. This callback is invoked only | ||
| * for the Passkey Entry method as defined in Core Specification Vol. 3, Part H. Which | ||
| * device in the pairing is showing the passkey depends on the IO capabilities of the | ||
| * device; see Table 2.8 of the Bluetooth Core Specification V6.0, Vol. 3, Part H for more |
There was a problem hiding this comment.
better not to specify version, so we don't need to update it with every spec release. The way core spec is developed guarantees that existing section numbers will not change in future specs.
| * device; see Table 2.8 of the Bluetooth Core Specification V6.0, Vol. 3, Part H for more | |
| * device; see Table 2.8 of the Bluetooth Core Specification, Vol. 3, Part H for more |
There was a problem hiding this comment.
should I do it here? I don't know actually since this is upstream commit? any suggestion?
There was a problem hiding this comment.
It is better to fix this in upstream instead of noup here.
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
7 times, most recently
from
604af05 to
800163b
Compare
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
2 times, most recently
from
0f113a4 to
d64d4dd
Compare
rlubos
left a comment
rlubos
left a comment
There was a problem hiding this comment.
[nrf noup] Revert "[nrf fromtree] bluetooth: mesh: use new Kconfig CONFIG_PSA_CRYPTO"
Please use the default revert title (Revert "[nrf fromtree] bluetooth: mesh: use new Kconfig CONFIG_PSA_CRYPTO"), no sauce tags, otherwise our tooling will get confused.
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
from
d64d4dd to
6f5f768
Compare
This https://github.com/nrfconnect/sdk-zephyr/actions/runs/19500260647/job/55812322763?pr=3466 was the reason I added noup to because what happens is: I need commits: But a46c319 picks up some piece of change from this 90036ce commit so it fails because it has a conflict, so I pick it too, to have a smooth cherry-pick without conflict, then at the end I revert it but revert also comes in with a conflict. To hide the conflict I added [nrf noup]. I don't know what am I supposed to do, cherry-pick all dependencies and fight, how deep should I dig? |
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
from
6f5f768 to
1fbe278
Compare
This commit is cherry-picked in this PR: #3431 but also have some problems in passing CI. |
|
@carlescufi Ok to override the CI for this particular case? The conflict was just a migration guide entry. |
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
from
1fbe278 to
86a13c4
Compare
Adds the BT_APP_PASSKEY Kconfig, which allows the application to provide passkeys for pairing using the new `app_passkey()` callback. This is an alternative to BT_FIXED_PASSKEY, which will be deprecated in a later commit. Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no> (cherry picked from commit 6c64054) Signed-off-by: alperen sener <alperen.sener@nordicsemi.no>
The BT_FIXED_PASSKEY Kconfig option is being deprecated, and is replaced by BT_APP_PASSKEY. The reason for the deprecation is an upcoming errata, ES-24489, which mandates that a new passkey shall be generated for each pairing procedure. Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no> (cherry picked from commit 82cfb5a) Signed-off-by: alperen sener <alperen.sener@nordicsemi.no>
Updates the bt shell API to use the new Kconfig option BT_APP_PASSKEY instead of BT_FIXED_PASSKEY as this is being deprecated. Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no> (cherry picked from commit b6252b5) Signed-off-by: alperen sener <alperen.sener@nordicsemi.no>
m-alperen-sener
force-pushed
the
fixed_passkey_derecation
branch
from
86a13c4 to
2d079a1
Compare
|
We can merge this now, manifest PR is green. |
5 participants
Cherry-pick for deprecating fixed passkey.