-
Notifications
You must be signed in to change notification settings - Fork 732
[nrf noup] Bluetooth: Temporarily add C++ over internal header file #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This unblocks a specific use case where this header file is included. Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
alwa-nordic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified keys.h is correct C++ (with GNU extension for zero-sized arrays).
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can this not be upstreamed?
|
Agreed, the overhead of doing a |
|
@nordicjm , @carlescufi We do not want to have a C++ header guard in this file upstream. Already agreed upon with the Bluetooth maintainer @alwa-nordic . This change is also temporary because we intend to provide a public API solving the customers request |
Then in the file that needs it do: This as a hack temp. no-up is absolutely ridiculous |
|
@nordicjm , this has already been discussed internally with the maintainer. |
This unblocks a specific use case where this header file is included.