Skip to content

Conversation

@rugeGerritsen
Copy link
Contributor

This unblocks a specific use case where this header file is included.

This unblocks a specific use case where this header file is included.

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
Copy link
Contributor

@alwa-nordic alwa-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified keys.h is correct C++ (with GNU extension for zero-sized arrays).

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can this not be upstreamed?

@carlescufi
Copy link
Contributor

Agreed, the overhead of doing a fromlist here i negligible? it's a trivial patch

@rugeGerritsen
Copy link
Contributor Author

@nordicjm , @carlescufi We do not want to have a C++ header guard in this file upstream. Already agreed upon with the Bluetooth maintainer @alwa-nordic . This change is also temporary because we intend to provide a public API solving the customers request

@nordicjm
Copy link
Contributor

@nordicjm , @carlescufi We do not want to have a C++ header guard in this file upstream. Already agreed upon with the Bluetooth maintainer @alwa-nordic . This change is also temporary because we intend to provide a public API solving the customers request

Then in the file that needs it do:

#ifdef __cplusplus
extern "C" {
#endif

#include <file/path/.c>

#ifdef __cplusplus
}
#endif

This as a hack temp. no-up is absolutely ridiculous

@rugeGerritsen
Copy link
Contributor Author

@nordicjm , this has already been discussed internally with the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants