Duplicate file and whitespace cleanup#19
Closed
turboencabulator wants to merge 2 commits intonrnrnr:masterfrom
Closed
Duplicate file and whitespace cleanup#19turboencabulator wants to merge 2 commits intonrnrnr:masterfrom
turboencabulator wants to merge 2 commits intonrnrnr:masterfrom
Conversation
Makefile.gnu and Makefile.make are identical. Only keep one.
Trim trailing whitespace at EOL/EOF. Move recipes to their own line. Miscellaneous consistency improvements.
Owner
|
Can you please remind me what problem is being solved here? |
Contributor
Author
|
This is another part of breaking up PR #10. I've got other pieces on the way, but holding them back until this is in so I don't have merge conflicts. |
Owner
|
I reviewed the discussion on that PR, and I didn't find anything to support all these changes in whitespace. I hate to say it, but they look gratuitous. Why not simply drop this patch? |
Contributor
Author
Owner
|
Well, I'm skeptical, but you've put more effort into this than I have, and I don't see that the patch does real harm. So I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placing most of these type of changes into a single PR so as not to pollute other PRs.