Merged
Conversation
Check their status using && instead of assuming they succeed. Always execute them in a subshell. Some flavors of make allow all commands to run in the same shell.
$< should only be used in suffix rules for portability. Replace the all-scripts target with targets for each .awk file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a few replacements that didn't make it into #17:
$@and$<in the rules (particularly suffix rules), except don't use$<outside of pattern/suffix rules since it isn't portable (a GNU Make extension for the first prerequisite).cd dir; cmdwith(cd dir && cmd).makewith$(MAKE).Three other small changes that help when using these automatic variables:
$@as appropriate. Removes the need totouch all-scriptsto prevent unnecessarily rebuilding these.chmod +xcommands to where the target file is created so these can also use$@..nw.osuffix rule from src/c/Makefile, instead relying on the.nw.crule followed by the usually built-in.c.orule.