Skip to content

test: piece_arpeggio の env override / global config テスト追加#534

Merged
j5ik2o merged 2 commits intomainfrom
test/piece-arpeggio-missing-coverage
Mar 19, 2026
Merged

test: piece_arpeggio の env override / global config テスト追加#534
j5ik2o merged 2 commits intomainfrom
test/piece-arpeggio-missing-coverage

Conversation

@j5ik2o
Copy link
Collaborator

@j5ik2o j5ik2o commented Mar 19, 2026

概要

PR #521 (piece_arpeggio ポリシー) で不足していたテストカバレッジを追加。

  • env override テスト (TAKT_PIECE_ARPEGGIO JSON / 個別 boolean、global / project)
  • global config の load / save round-trip テスト

背景

PR #521 の Codex レビューで "non-blocking recommendation" として指摘されていた項目。
他の同種ポリシー (sync_conflict_resolver, piece_mcp_servers) では追加済みだが、
piece_arpeggio のみ漏れていた。

テスト計画

  • npx vitest run src/__tests__/config-env-overrides.test.ts パス
  • npx vitest run src/__tests__/globalConfig-defaults.test.ts パス

- Env override: TAKT_PIECE_ARPEGGIO JSON for global/project config
- Env override: TAKT_PIECE_ARPEGGIO_CUSTOM_MERGE_INLINE_JS for global
- Env override: TAKT_PIECE_ARPEGGIO_CUSTOM_DATA_SOURCE_MODULES for project
- Global config: load piece_arpeggio from config.yaml
- Global config: save and reload piece_arpeggio round-trip
- Add TAKT_PIECE_ARPEGGIO_CUSTOM_MERGE_FILES env override test (global)
- Include customMergeFiles in global config save/reload round-trip
@j5ik2o j5ik2o merged commit 8d7982e into main Mar 19, 2026
3 of 4 checks passed
@j5ik2o j5ik2o deleted the test/piece-arpeggio-missing-coverage branch March 19, 2026 06:56
@nrslib nrslib mentioned this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant