test(angular-rsbuild): test compiler helper #96
Merged
+191
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ffcddd1.
☁️ Nx Cloud last updated this comment at |
BioPhoton
commented
May 15, 2025
| */ | ||
| export async function deleteOutputDir( | ||
| root: string, | ||
| outputPath: string, | ||
| emptyOnlyDirectories?: string[] | ||
| preserveDirs?: string[] |
There was a problem hiding this comment.
switched to preserveDirs as it reflects more what the logic wants to achieve
BioPhoton
commented
May 15, 2025
Comment on lines
+49
to
+51
| // compute its path relative to `root`, then recurse as in deleteOutputDir resolve is called on root | ||
| const rel = relative(root, fullEntry); | ||
| await deleteOutputDir(root, rel, preserveDirs); |
There was a problem hiding this comment.
the recursive call was:
- passing a already resolved path
- not passing
preserveDirsarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
unittests for compiler helpersintegrationtests for compiler helpersdeleteOutputDirto work in recursive files