Skip to content

Conversation

@sathabbott
Copy link
Collaborator

Pushing changes needed for hydrator package dependency.
https://github.com/robjectifier/rhydrator

@sathabbott sathabbott requested a review from nsmith- December 18, 2025 22:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.32%. Comparing base (3b6f3d5) to head (1444639).

Files with missing lines Patch % Lines
src/rootfilespec/rntuple/schema.py 90.90% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   91.36%   91.32%   -0.04%     
==========================================
  Files          36       36              
  Lines        2723     2722       -1     
==========================================
- Hits         2488     2486       -2     
- Misses        235      236       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sathabbott sathabbott changed the title Sync for use by hydrator. Remove a TStreamer assertion, minor updates to rntuple classes. Update to python 3.10. Sync for use by hydrator. Remove a TStreamer assertion. Dec 19, 2025
Copy link
Owner

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues. If you want to break this into a py3.10 migration PR and separately a PR for updating the RNTuple interface that would look cleaner but up to you.

@nsmith- nsmith- merged commit 01a8861 into nsmith-:main Dec 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants