🐛🔧✓ Fixed a minor bug in downsampling. Changed default offset to 0.#3
Open
Kenil-Ajudiya wants to merge 3 commits intonsmspotlight:mainfrom
Open
🐛🔧✓ Fixed a minor bug in downsampling. Changed default offset to 0.#3Kenil-Ajudiya wants to merge 3 commits intonsmspotlight:mainfrom
Kenil-Ajudiya wants to merge 3 commits intonsmspotlight:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug in the downsampling logic and updates the default offset parameter. The bug fix prevents a NameError when writing downsampled-only data, and the offset change modifies the default behavior of the data extraction pipeline.
- Fixed incorrect variable reference in downsampled data writing path
- Changed default offset parameter from 64 to 0 in the main function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor pull goes a long way...