Conversation
fformica
approved these changes
Mar 10, 2025
Member
There was a problem hiding this comment.
I'd like to log the result to see if the name is just corrupted or we followed a bad pointer or something, but if it is corrupted it may be random data as well, so perhaps less risky to drop it completely.
All in all I'm satisfied that with this PR good names should be decoded and zero-terminated and bad names won't cause a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight changes and bug fixes in hope of fixing crash errors in dns01.ord03.mnet2 stripe agents
Return 0 instead of encodedNameLength for a simpler more robust error handling process
Some clearer logging