-
Notifications
You must be signed in to change notification settings - Fork 5
Develop WD1 decoding #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bpalmeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not real hehe
bpalmeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request
aa6ef26 to
c08aad7
Compare
|
Sorry for bloating PRs, but in this PR I'm including a smarter way to process data that is memory efficient. We now have a writer object that can writes individual waveforms to the h5 file. I need to add forwards compatible functions for reading datasets lazily now, and make them EDIT: To avoid this getting out of hand, I'll add tests for the readers and writers in a separate PR, or perhaps I'll extract them into a separate PR entirely (the smarter but possibly more complicated move git-wise). EDIT 2 (29/03): The readers and writers are also a bit stupid, and waste a lot of time with IO operations (reopening datasets that should rest open at all times). I tried to think of a smart solution to keep them open but it gets complicated (or I'm tired, probably both). |
5dceacf to
761d187
Compare
|
Test coverage now near 100%, although works on a 'whole function' basis, due to the reader, writers, and the decoder having limited compartmentalisation. Improved functionality would be nice, but currently it works as expected. I'd say its ready for a 'light' review, with the knowledge that almost every issue found will become technical debt :) |
a64f7d3 to
c3c74fe
Compare
This PR introduces the functionality of processing into MULE, with single channel decoding from waveDump 1
.datfiles now being possible. Addresses #11 which will be resolved when this is complete.The data is stored in h5 files with a storage path and name provided by the user. The h5 format matches that decoded in wavedump 2.
This PR rests on top of #10, and as such includes all the new bells and whistles. Config files, integration with the mule executable.
Things still needed