use pytest fixtures and create conftest.py #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a conftest.py from which to manage fixtures
jwaiton
requested changes
Apr 14, 2025
Member
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
Excellent work! This removes more lines of code than it introduces (which is almost always a good thing). I only have a minor nitpick addressed in the other comment.
packs/tests/conftest.py
Outdated
| return MULE_dir + '/packs/tests/data/' | ||
|
|
||
| @pytest.fixture(scope="session") | ||
| def ch3wd2_dir(data_dir): |
Member
There was a problem hiding this comment.
As ch3wd2_dir is pointing to a binary file for testing rather than a directory, I'd change this fixtures name to something like ch3wd2_bin, or WD2_3ch_dat. The interpretation is up to you :)
jwaiton
approved these changes
Apr 14, 2025
Member
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
This PR simplifies the use of fixtures with conftest.py making the code less repetitive and easier to read. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27 . use pytest fixtures to restructure the various calling of directories in processing and setup tests; and create a conftest.py from which to manage fixtures