Add typing to ThresholdDecryptionResponse.decryption_share#125
Closed
fjarri wants to merge 1 commit intonucypher:mainfrom
Closed
Add typing to ThresholdDecryptionResponse.decryption_share#125fjarri wants to merge 1 commit intonucypher:mainfrom
ThresholdDecryptionResponse.decryption_share#125fjarri wants to merge 1 commit intonucypher:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 59.77% 59.60% -0.17%
==========================================
Files 19 19
Lines 4097 4112 +15
==========================================
+ Hits 2449 2451 +2
- Misses 1648 1661 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThresholdDecryptionResponseThresholdDecryptionResponse.decryption_share
Contributor
Author
|
See the comment in #121. Cannot be fixed at the moment due to some unfortunate design choices. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ThresholdDecryptionResponse.__init__now takes a typeddecryption_shareinstead of bytesThresholdDecryptionResponse.decryption_shareis also typedIssues fixed/closed:
Notes:
This changes the ABI of
ThresholdDecryptionResponseFor a test I used a pre-serialized
DecryptionShareSimple. Making it via the API is possible, but much more complicated.