Skip to content

Address PR comments in #74 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-roslaniec merged 4 commits into from
Aug 28, 2023
Merged

Address PR comments in #74 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
088c62c
address pr comments in #74
piotr-roslaniec Aug 25, 2023
5b7b388
fix clippy for rust@1.7.2
piotr-roslaniec Aug 25, 2023
892a7c9
fix wasm-pack msrv compatibility
piotr-roslaniec Aug 25, 2023
c0796cf
set msrv for wasm tools on ci
piotr-roslaniec Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/nucypher-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ defaults:
env:
CARGO_INCREMENTAL: 0
RUSTFLAGS: "-Dwarnings"
WASM_PACK_VERSION: 0.12.0
WASM_OPT_VERSION: 0.114.1

jobs:

Expand Down Expand Up @@ -50,8 +52,8 @@ jobs:
strategy:
matrix:
rust:
- 1.67 # MSRV
- stable
- 1.71 # MSRV for wasm-opt & wasm-pack
# - stable
target:
- wasm32-unknown-unknown

Expand All @@ -63,7 +65,7 @@ jobs:
toolchain: ${{ matrix.rust }}
target: ${{ matrix.target }}
override: true
- run: cargo install wasm-opt wasm-pack
- run: cargo install wasm-opt@${{ env.WASM_OPT_VERSION }} wasm-pack@${{ env.WASM_PACK_VERSION }}
- run: cd ../nucypher-core-wasm && wasm-pack test --node

yarn-test:
Expand All @@ -83,7 +85,7 @@ jobs:
toolchain: ${{ matrix.rust }}
target: ${{ matrix.target }}
override: true
- run: cargo install wasm-opt wasm-pack
- run: cargo install wasm-opt@${{ env.WASM_OPT_VERSION }} wasm-pack@${{ env.WASM_PACK_VERSION }}
- run: make
working-directory: nucypher-core-wasm
- uses: borales/actions-yarn@v3.0.0
Expand Down
Loading