Housekeeping

[fjarri]

Type of PR:

• Other

Required reviews:

• 2

What this does:
Housekeeping tasks:

• Update the resolver and fix clippy warnings
• Bump pyo3 to 0.27
• Use serde-encoded-bytes crate instead of serde_bytes module
• Use secrecy crate instead of secret_box module
• Bump wasm-bindgen-derive to 0.3
• Bump zeroize to 1.8

[fjarri]

Probably will need to bump MSRV, will know when someone enables CI for me :)

[codecov-commenter]

Codecov Report

❌ Patch coverage is 59.45946% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.78%. Comparing base (6f692dd) to head (fe0f82b).

Files with missing lines	Patch %	Lines
umbral-pre/src/bindings_python.rs	0.00%	42 Missing ⚠️
umbral-pre/src/keys.rs	64.51%	11 Missing ⚠️
umbral-pre/src/bindings_wasm.rs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   58.17%   56.78%   -1.40%     
==========================================
  Files          17       16       -1     
  Lines        3118     2520     -598     
==========================================
- Hits         1814     1431     -383     
+ Misses       1304     1089     -215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[derekpierre]

To confirm, the actual serialization doesn't change, correct? i.e. the serialized bytes remain the same.

[fjarri]

Should be the same - it's still serialized as a byte slice (serde got a long-standing problem with constant-sized arrays). The container type (GenericArray014) only serves to define the specific AsRef and TryFrom impls that will be used for (de)serialization, because static arrays, slices, and GenericArray types have different ones.

I can test it out though.

[derekpierre]

Let’s double-check. I'd like to ensure that there isn’t a backward compatibility issue where data serialized using the previous code can’t be properly deserialized after this change.

[fjarri]

Ok so in the rebased PR I added a "vector tests" commit just before the switch to serde-encoded-bytes, checking against hardcoded serialization results, and the tests still pass after the switch.

[derekpierre]

👍

[Copilot]

Pull Request Overview

This PR migrates from a custom SecretBox implementation to the secrecy crate and refactors serialization using serde-encoded-bytes. Key changes include:

• Replaced custom SecretBox and serde_bytes modules with secrecy crate (v0.10) and serde-encoded-bytes (v0.2)
• Updated API calls from as_secret()/as_mut_secret() to expose_secret()/expose_secret_mut()
• Changed SecretBox::new() to SecretBox::init_with() for initialization
• Updated PyO3 bindings from v0.18 to v0.27 with corresponding API changes (PyModule → Bound<'_, PyModule>, PyObject → Py<PyAny>, with_gil → attach)
• Updated wasm-bindgen-derive from v0.2 to v0.3
• Bumped MSRV from 1.70.0 to 1.81.0

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
umbral-pre/src/serde_test.rs	Added new test helper module extracting serialization roundtrip testing
umbral-pre/src/serde_bytes.rs	Deleted custom serde serialization utilities
umbral-pre/src/secret_box.rs	Deleted custom SecretBox implementation
umbral-pre/src/lib.rs	Updated module declarations and removed SecretBox export
umbral-pre/src/keys.rs	Migrated to secrecy crate API and serde-encoded-bytes
umbral-pre/src/key_frag.rs	Updated SecretBox usage and serialization
umbral-pre/src/hashing.rs	Updated SecretBox API calls
umbral-pre/src/evidence.rs	Updated serde attribute for serialization
umbral-pre/src/dem.rs	Updated SecretBox initialization patterns
umbral-pre/src/curve.rs	Migrated serialization to serde-encoded-bytes
umbral-pre/src/capsule_frag.rs	Updated SecretBox usage
umbral-pre/src/capsule.rs	Updated SecretBox initialization and exposure
umbral-pre/src/pre.rs	Updated SecretBox API calls
umbral-pre/src/bindings_wasm.rs	Moved helper functions to wasm-bindgen-derive crate
umbral-pre/src/bindings_python.rs	Updated PyO3 API for v0.27 compatibility
umbral-pre/src/bench.rs	Updated imports
umbral-pre/Cargo.toml	Added new dependencies and updated versions
umbral-pre-python files	Updated PyO3 v0.27 compatibility
Cargo.toml	Set resolver to version 2
.github/workflows/umbral-pre.yml	Updated MSRV to 1.81.0

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using an exact version pin (=0.14.7) for generic-array is very restrictive and may cause dependency conflicts in downstream crates. Consider using a more flexible version constraint like '0.14.7' or '^0.14.7' unless there's a specific reason for the exact pin.

Suggested change

	generic-array = { version = "=0.14.7", features = ["zeroize"] }
	generic-array = { version = "0.14.7", features = ["zeroize"] }

[fjarri]

Unfortunately the author of generic-array screwed everyone by adding deprecation notices to every single API item in 0.14.8 (in an effort to make people switch to 1.x I guess, see fizyk20/generic-array#158). But the RustCrypto stack libraries we depend on still use 0.14, so we can't upgrade.