Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #254 +/- ##
==========================================
+ Coverage 83.66% 84.20% +0.54%
==========================================
Files 37 37
Lines 967 1013 +46
Branches 121 129 +8
==========================================
+ Hits 809 853 +44
- Misses 152 153 +1
- Partials 6 7 +1
|
Member
|
Do we need a TMK format after the changes in nucypher/ferveo#149 (and TBD changes in nucypher-core)? |
Member
Yes. This is the goal of nucypher/nucypher#3194. I think (?) this PR was created before as a stop gap measure, but it is unclear to me that this PR is needed or should be merged. @piotr-roslaniec ? |
Contributor
Author
|
This PR was originally started 3 weeks ago, so perhaps it has outlived its usefulness. If we don't need to bridge the gap, I'd be okay with closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: