Conversation
piotr-roslaniec
requested review from
KPrasch,
cygnusv,
derekpierre,
jMyles,
manumonti and
theref
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@nucypher/nucypher-core": "^0.11.0", | ||
| "@nucypher/nucypher-core": "file:../nucypher-core/nucypher-core-wasm/pkg", |
There was a problem hiding this comment.
I suppose this line will be changed when nucypher/nucypher-core#77 is merged, right?
There was a problem hiding this comment.
Yes, but specifically when we release @nucypher/nucypher-core@0.12.0 on npm.
|
Bundled size for the package is listed below: build/main/src/characters: 74.22 KB |
| @@ -48,10 +49,13 @@ export class ThresholdDecrypter { | |||
| conditionExpr: ConditionExpression, | |||
| ciphertext: Ciphertext | |||
There was a problem hiding this comment.
Should this instead be ThresholdMessageKit and not Ciphertext...?
| ciphertext: Ciphertext, | ||
| acp: AccessControlPolicy |
There was a problem hiding this comment.
@piotr-roslaniec Should this just be ThreshodlMessageKit? It has the ciphertext and the acp in it...?
|
@derekpierre I will fix those in a follow-up PR. |
3 participants
Type of PR:
Required reviews:
What this does:
nucypher-coreversionIssues fixed/closed:
Why it's needed:
Notes for reviewers:
@nucypher/nucypher-core@0.12.0to be released on npm to merge this PRnucypher-coreversion