Closed
Conversation
4a63741 to
3ec1fb0
Compare
Codecov Report
@@ Coverage Diff @@
## alpha #294 +/- ##
==========================================
- Coverage 81.25% 0.00% -81.26%
==========================================
Files 36 40 +4
Lines 1035 1074 +39
Branches 110 117 +7
==========================================
- Hits 841 0 -841
- Misses 186 1019 +833
- Partials 8 55 +47
📢 Have feedback on the report? Share it here. |
b36412b to
26ff346
Compare
26ff346 to
ca9e163
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do
changesetsfor package release managementpreandtacomodules. Use TS andtypecheckin examples.exportsfield inpackage.json(currently breaks tests inpackages/taco*.mdfilesexamplesare getting built, tested, etc. on CIprepackage, similarly totacopackagepeerDependenciesType of PR:
Required reviews:
What this does:
shared,preandtacopackagespnpmas a package managerjestwithvitestethers-contractsgenerated bytypechainare no longer stored in the repoIssues fixed/closed:
Why it's needed:
Notes for reviewers:
nucypher-tsdemos (like https://github.com/nucypher/nucypher-ts-demo-tdec) as examples in./apps./packages/*into a separate PR (functional vs OOO/character-based API)./examplesto usetacoorpre, or both?