Support encryptor allowlist

[piotr-roslaniec]

Type of PR:

• Feature

Required reviews:

• 2

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

• Fixes Support encryptor allowlist #305
• Fixes Expose registerEncrypters from taco API #324

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

• Replacing string usage with ChecksumAddress usage where possible
• Are there any other facilities that we should provide to make encrypter onboarding easier?
• Supplemented by isAuthorizedEncrypter added in Refactor packages APIs #301
• ethers-typechain directory contains auto-generated code and need not be reviewed
• Rebase & merge after implementing Use @nucypher/nucypher-contracts NPM package instead of custom registry #310

[codecov-commenter]

Codecov Report

Merging #306 (fac82b6) into monorepo (80018e5) will decrease coverage by 0.40%.
The diff coverage is 51.72%.

@@             Coverage Diff              @@
##           monorepo     #306      +/-   ##
============================================
- Coverage     88.25%   87.86%   -0.40%     
============================================
  Files            33       33              
  Lines          2409     2430      +21     
  Branches        205      205              
============================================
+ Hits           2126     2135       +9     
- Misses          254      266      +12     
  Partials         29       29              

Files	Coverage Δ
packages/pre/src/characters/bob.ts	85.61% <100.00%> (ø)
packages/pre/src/cohort.ts	89.28% <100.00%> (ø)
packages/taco/src/conditions/const.ts	100.00% <100.00%> (ø)
packages/pre/src/kits/retrieval.ts	77.27% <0.00%> (ø)
packages/pre/src/policy.ts	83.13% <50.00%> (+0.09%)	⬆️
packages/taco/src/taco.ts	86.99% <42.85%> (-9.13%)	⬇️

[theref]

is there a difference between this _abi and packages/shared/abis/GlobalAllowList.json?

[piotr-roslaniec]

This is code generated by typechain, the difference includes generated (inferred) types.

[theref]

ok cool, so as one changes, the other will be automatically kept up to date by typechain

[KPrasch]

Looking good, although if there's an incoming PR that will integrate nucypher-contracts >= v0.5.0 do we want to wait for that first?

[piotr-roslaniec]

(...) there's an incoming PR that will integrate nucypher-contracts v0.5.0 do we want to wait for that first?

Yes, I will add this information to the PR description.

[derekpierre]

We should be careful here. Both tapir and lynx use Mumbai but have different GlobalAllowList contracts:

• Lynx: 0x7b521E78CFaf55fa01433181d1D636E7e4b73243
• Tapir: 0x5Ff235481bbDBF5dFCC908d987506FA6a8696678

How would this resolution work currently? Keying by "domain" is better than solely by blockchain/chain_id.

[piotr-roslaniec]

Will address post #314 changes