Expose Porter domains using helper methods by piotr-roslaniec · Pull Request #312 · nucypher/taco-web

piotr-roslaniec · 2023-10-05T13:34:17Z

Type of PR:

Feature

Required reviews:

1

Issues fixed/closed:

Fixes Update Porter network configuration for @nucypher/* packages #311

Notes for reviewers:

Based on Refactor packages APIs #301
In hindsight, could have been part of Refactor packages APIs #301
Rebased over Release @nucypher/taco #315
Support tapir, mainnet and lynx networks. Test examples and demos against lynx.

codecov-commenter · 2023-10-06T10:20:01Z

Codecov Report

Merging #312 (21f6d93) into monorepo (899c9d2) will decrease coverage by 0.08%.
Report is 10 commits behind head on monorepo.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           monorepo     #312      +/-   ##
============================================
- Coverage     88.25%   88.17%   -0.08%     
============================================
  Files            33       33              
  Lines          2409     2394      -15     
  Branches        205      205              
============================================
- Hits           2126     2111      -15     
  Misses          254      254              
  Partials         29       29

Files	Coverage Δ
packages/pre/src/index.ts	`100.00% <100.00%> (ø)`
packages/taco/src/index.ts	`100.00% <100.00%> (ø)`
packages/taco/src/taco.ts	`95.87% <100.00%> (-0.21%)`	⬇️

derekpierre · 2023-10-06T13:17:19Z

packages/pre/src/porter.ts

+type PreDomain = 'oryx';
+
+export const PRE_DOMAIN: Record<string, PreDomain> = {
+  TESTNET: 'oryx',


Was this supposed to be tapir?

Suggested change

TESTNET: 'oryx',

TESTNET: 'tapir',

I'm not sure. I thought that @nucypher/nucypher-ts@0.10.0, the vanilla PRE release, was working on oryx. tapir was used by tDec-PRE. I think these two are not compatible. Not sure what to do here, other than to update @nucypher/pre to use the current nucypher-core version and make sure it works on tapir.

Support tapir, mainnet and lynx networks. Test examples and demos against lynx.

@derekpierre What was the conclusion here? To support tapir, mainnet, and lynx networks in both PRE and TACo?

Yes. All possible TACo domains should be allowed: tapir, lynx, mainnet.

derekpierre · 2023-10-06T13:20:35Z

packages/shared/src/porter.ts

+export type PorterNetwork = keyof typeof porterUri;

-export const getPorterUri = (network: Network): string => {
-  const uri = PORTER_URIS[network];
+export const getPorterUri = (network: PorterNetwork): string => {


Can we use "domain" instead of "network"?

KPrasch · 2023-10-06T14:07:18Z

packages/pre/src/porter.ts

@@ -0,0 +1,17 @@
+import { getPorterUri as doGetPorterUri } from '@nucypher/shared';
+
+type PreDomain = 'oryx';


This domain is planned to be EOL after the next release, Shall we update it?

Suggested change

type PreDomain = 'oryx';

type PreDomain = PRE_DOMAIN.TESTNET;

We can update it now, sure. I gather from comments in this PR that it's supposed to be tapir?

WRT to the line: Notice how type PreDomain = 'oryx'; is used in PRE_DOMAIN type definition:

export const PRE_DOMAIN: Record<string, PreDomain> = { TESTNET: 'oryx', };

It works here like an enum - It describes the legal values in the PRE_DOMAIN dictionary.

piotr-roslaniec changed the title ~~chore(examples): add a nextjs example~~ Expose Porter domains from helper methods Oct 5, 2023

piotr-roslaniec changed the title ~~Expose Porter domains from helper methods~~ Expose Porter domains using helper methods Oct 5, 2023

piotr-roslaniec force-pushed the porter-domains branch from 234d8cc to cb7ed57 Compare October 6, 2023 10:14

piotr-roslaniec marked this pull request as ready for review October 6, 2023 10:20

piotr-roslaniec force-pushed the porter-domains branch 3 times, most recently from 8cf7e21 to e53419a Compare October 6, 2023 12:23

piotr-roslaniec requested review from KPrasch, cygnusv, derekpierre, jMyles, manumonti and theref October 6, 2023 12:28

derekpierre reviewed Oct 6, 2023

View reviewed changes

KPrasch reviewed Oct 6, 2023

View reviewed changes

piotr-roslaniec added 8 commits October 16, 2023 09:30

chore(release): release @nucypher/taco:0.1.0-rc.0

7cea7dc

chore(release): release @nucypher/shared:0.1.0-rc.0

23644ab

chore(release): release @nucypher/taco:0.1.0-rc.1

120fd45

chore(typechain): remove typechain from postinstall steps

9397c13

chore(release): release @nucypher/shared:0.1.0-rc.1

b0a2ca9

chore(release): release @nucypher/taco:0.1.0-rc.2

3b08a34

feature(porter): add porter domains for taco and pre

149fb20

apply pr suggestions

76911fa

piotr-roslaniec force-pushed the porter-domains branch from 7abe95f to 76911fa Compare October 16, 2023 08:01

piotr-roslaniec mentioned this pull request Oct 16, 2023

Use @nucypher/nucypher-contracts contract registry #314

Merged

piotr-roslaniec force-pushed the porter-domains branch from 8323ae1 to 9b6de63 Compare October 16, 2023 19:31

apply pr suggestions

21f6d93

piotr-roslaniec force-pushed the porter-domains branch from 9b6de63 to 21f6d93 Compare October 16, 2023 19:38

KPrasch approved these changes Oct 17, 2023

View reviewed changes

piotr-roslaniec merged commit 18b14e2 into nucypher:monorepo Oct 17, 2023

piotr-roslaniec deleted the porter-domains branch October 17, 2023 10:56

piotr-roslaniec mentioned this pull request Oct 18, 2023

Update Porter network configuration for @nucypher/* packages #311

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose Porter domains using helper methods#312

Expose Porter domains using helper methods#312
piotr-roslaniec merged 9 commits intonucypher:monorepofrom
piotr-roslaniec:porter-domains

piotr-roslaniec commented Oct 5, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Oct 6, 2023 •

edited

Loading

Uh oh!

derekpierre Oct 6, 2023

Uh oh!

piotr-roslaniec Oct 6, 2023 •

edited

Loading

Uh oh!

piotr-roslaniec Oct 6, 2023

Uh oh!

piotr-roslaniec Oct 16, 2023

Uh oh!

derekpierre Oct 16, 2023

Uh oh!

derekpierre Oct 6, 2023

Uh oh!

KPrasch Oct 6, 2023

Uh oh!

piotr-roslaniec Oct 6, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,17 @@
		import { getPorterUri as doGetPorterUri } from '@nucypher/shared';

		type PreDomain = 'oryx';

	type PreDomain = 'oryx';
	type PreDomain = PRE_DOMAIN.TESTNET;

Conversation

piotr-roslaniec commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

derekpierre Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

piotr-roslaniec Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piotr-roslaniec Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

piotr-roslaniec Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

derekpierre Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

derekpierre Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

KPrasch Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

piotr-roslaniec Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

piotr-roslaniec commented Oct 5, 2023 •

edited

Loading

codecov-commenter commented Oct 6, 2023 •

edited

Loading

piotr-roslaniec Oct 6, 2023 •

edited

Loading

piotr-roslaniec Oct 6, 2023 •

edited

Loading