Migrate from ethers-v5 to viem#421
Closed
piotr-roslaniec wants to merge 5 commits intonucypher:mainfrom
Closed
Conversation
3 tasks
f4f9bd8 to
0a33a66
Compare
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
271d364 to
eb9cc4e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 88.00% 87.89% -0.12%
==========================================
Files 33 33
Lines 2702 2767 +65
Branches 233 239 +6
==========================================
+ Hits 2378 2432 +54
- Misses 293 300 +7
- Partials 31 35 +4 ☔ View full report in Codecov by Sentry. |
c76216e to
4806ac4
Compare
4806ac4 to
8edd523
Compare
8edd523 to
1fb32bd
Compare
Contributor
Author
|
Currently fails due to some incompatibility between |
Member
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ethers-v5withviemWalletClientandPublicClientWhy it's needed:
Notes for reviewers:
tapirCI job #445 to keep this PR tested (can drop these commits if needed)ethersusagetypechainusage (based onethers)abitype/zodto validatefunctionAbiinstead of relying onethersethers-v5toviem#271