Conversation
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
444159a to
08184cb
Compare
08184cb to
e72c07e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 23.97% 23.97%
=======================================
Files 62 62
Lines 9792 9792
Branches 260 260
=======================================
Hits 2348 2348
Misses 7385 7385
Partials 59 59 ☔ View full report in Codecov by Sentry. |
taco@0.2.0
221a6f4 to
d8294f9
Compare
| "glob-parent@<5.1.2": ">=5.1.2", | ||
| "nth-check@<2.0.1": ">=2.0.1", | ||
| "@nucypher/nucypher-core": "0.13.0-alpha.1" | ||
| "@nucypher/nucypher-core": "^0.14.1" |
There was a problem hiding this comment.
Judging by nucypher/nucypher-core#89 there are no concerns about 0.14.1 not being compatible with nodes running 0.13.0, correct? The breaking changes were limited to the wasm bindings, which the nodes don't care about.
There was a problem hiding this comment.
Yes, these changes are strictly for nucypher-core-wasm and there is no impact on Python users.
| { | ||
| "name": "@nucypher/taco", | ||
| "version": "0.1.0", | ||
| "version": "0.2.2", |
There was a problem hiding this comment.
I messed up and published a bad build. I yanked previous versions, but npmjs.com doesn't allow republishing so I had to bump the version.
There was a problem hiding this comment.
Ah ok 👍
Should the demos (taco-demo, taco-nft-demo) update their dependency to 0.2.2?
Type of PR:
Required reviews:
Why it's needed:
@nucypher/nucypher-contractswas updatedtaco-webworking fortapirusers