Draft
Conversation
derekpierre
changed the title
…nature on errors - change test expectation for signature decoding errors to expect undefined aggregatedSignature - remove unused parameters in mock functions for cleaner test setup
…ckage - remove duplicated SignResult and SigningOptions type definitions - add comment noting types are now imported from @nucypher/shared - improve code formatting and consistency
- import SignResult and SigningOptions from @nucypher/shared instead of local types - consolidate multiple imports from shared package into single import statement - improve code formatting and add missing trailing comma
- remove duplicate test case for different account types - standardize on EIP-4337 0.8.0 account abstraction version - streamline test descriptions for clarity
- change domain from lynx to TESTNET for consistency - update ritual ID and chain ID for correct test environment - standardize on EIP-4337 0.8.0 account abstraction version - conditionally skip integration tests when not in CI environment
…tions - reorder signUserOp function parameters for better logical grouping - move domain and cohortId before chainId and userOp - update parameter order: (provider, domain, cohortId, chainId, userOp, aaVersion, options, context, porterUris) - fix test calls to match new parameter order in unit tests and integration tests - add console.log for debugging porter signUserOp options usage
… have an actual released package.
- change signUserOp method to use 'data' instead of 'params' for POST request - aligns with other Porter methods that send data in request body - fixes 400 Bad Request error when signing user operations
- update test expectations to match new base64-encoded signing request format - tests now expect btoa(JSON.stringify(...)) instead of JSON.stringify(...)
- change signing request structure to match Python implementation - use snake_case field names (cohort_id, chain_id, signature_type) - serialize userOp as 'data' field instead of direct embedding - update tests to match new request format
- Use sorted JSON keys for user operations to match Python implementation - Update signing request structure with proper field names - Add error logging for debugging Porter API responses - Update tests to match new request format
- Add UserOperation type, UserOperationSignatureRequest class, and convertUserOperationToPython utility to shared/src/types.ts - Export new types and classes in shared/src/index.ts - Update taco/src/types.ts to re-export UserOperation from shared package - Eliminates duplication of UserOperation type definitions across packages
- Fix Porter client to use POST data instead of query params for /sign endpoint - Fix SigningCoordinator.getThreshold() to use signingCohorts(cohortId).threshold - Update signUserOp() to use shared conversion utilities and proper base64 encoding - Update tests to use shared conversion function and correct signature_type 'userOp' - Remove console.log statements and simplify integration test - All functionality now uses centralized types from shared package
- Updated SignResponse type to match new API response format with separated signatures and errors - Enhanced PorterClient.sign() with better error handling and response structure validation - Added debug logging to signing integration test - Fixed signer key mapping from operator to provider in signUserOp - Removed debug code for porter ursulas endpoint
- Remove private key security risk and use dummy address - Switch to Ethereum Sepolia testnet (chain ID 11155111) - Update RPC provider URL to publicnode.com - Change ritual ID to 1 - Fix test skip condition for CI environment
- Fix UserOperationSignatureRequest constructor to accept objects instead of strings - Remove double JSON stringification that caused address encoding errors - Update convertUserOperationToPython to handle null/empty values properly - Fix test expectations to match new data format and provider addresses - Resolve AddressEncoder errors by ensuring proper hex address format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update test expectations to use JSON.stringify for user_op field serialization - Rename digest field to messageHash in SignResult interface and all related code - Implement strict address validation that fails fast on invalid checksums - Fix Porter test mock response structure to match API format - Update integration test to use properly checksummed addresses Co-Authored-By: Kieran <kieranprasch@gmail.com>
…pt pattern - Remove complex try-catch blocks and manual error checking in signUserOp - Use direct destructuring of errors from Porter response - Trust Porter's response structure instead of adding validation overhead - Update tests to match new error handling pattern - Follow same approach as tacoDecrypt for consistent error handling
- Add async forSigningCohort static method to build context from signing cohort conditions - Fix import ordering and add missing ethers import - Update integration test to use new signing context method with await
- Add tests for happy path scenario with valid cohort conditions - Add error handling tests for network failures and invalid responses - Add tests for invalid hex decoding and JSON parsing errors - Add tests for complex compound condition structures - Add tests for invalid condition schema validation - Fix hex decoding in forSigningCohort method to handle contract responses
…ash validation - Remove returnAggregated option from SigningOptions type - Remove unused options parameter from signUserOp method - Add validation to ensure all Ursulas return same message hash - Throw error if message hashes don't match across signatures
…ash validation test - Remove returnAggregated options from existing tests - Add test case to verify error thrown when message hashes don't match - Update test calls to match new signUserOp signature
…erface - Remove SigningOptions import as no longer needed - Remove options parameter from signUserOp function signature - Update porter.signUserOp call to remove options parameter
…ons to 20 - Add **= (exponent) operator to variable operations for power calculations - Increase max sequential condition variables from 10 to 20 - Add tests for exponent operator with numeric and context parameter values
- Change operator from '**=' to 'pow' in OPERATOR_FUNCTIONS - Update pow operator to accept [base, exponent] array format - Update tests to reflect new pow operator syntax with array values - Aligns with nucypher backend API changes This change maintains backward compatibility by design - the operator name and signature change together, requiring explicit migration.
…ntics - Rename operator from 'pow' to '*pow=' in OPERATOR_FUNCTIONS - Update test suite to use '*pow=' operator name - Operator now computes: initial_value * (base ** exponent) - Aligns with nucypher backend API for token decimal conversions
Replace the generic *pow= operator with a specialized toTokenBaseUnits operator that takes decimals as a single value instead of [base, exponent] array. This aligns with the nucypher backend change that returns int instead of float to avoid precision loss for high-precision token decimal conversions.
Update comments to reflect current limits: - max 5 operands in compound condition - max 20 condition variables in sequential condition - max 4 nested levels (previously 2) Also increase ECDSA test chunkSize from 3 to 5.
Updates reflect toTokenBaseUnits operator and increased sequential condition limit from 5 to 20.
Add a new create2 operation to the variable operation system that computes Ethereum CREATE2 addresses locally, eliminating RPC calls to factory contracts for counterfactual address resolution. The operation takes an object value with deployerAddress and bytecodeHash fields, both supporting context variable resolution. This enables full Account Abstraction address derivation pipelines. Implements taco-web equivalent of nucypher/nucypher#3703.
Move create2ValueSchema from context.ts to variable-operation.ts and remove it from the paramOrContextParamSchema union. This prevents non-create2 operations from accepting create2-shaped values. Also tighten validation: deployerAddress and bytecodeHash now require 0x-prefixed hex strings instead of any plain string.
Remove OBJECT_VALUE_OPERATIONS exclusion list so create2 is covered by the regression backstop test for operations requiring a value. Use toContain assertion since create2 produces multiple errors.
…ema and the create2 operation schema. Revert change to test since no longer needed.
Add parametrized test ensuring all non-unary, non-create2 operations reject create2-shaped object values.
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Caches getParticipants and getThreshold results with a 10-second TTL to avoid redundant contract reads during short time windows. Cache is keyed by domain and cohortId, with a public clearCache() method for manual invalidation. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Covers cache hits, TTL expiry, per-domain and per-cohortId isolation, and manual cache clearing. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Move cache logic from SigningCoordinatorAgent into a reusable TtlCache class. Bump TTL from 10s to 60s per review feedback. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Reorder cache keys from field:domain:cohortId to domain:cohortId:field (broader to specific) and extract a cacheKey() helper to keep key structure consistent, per review feedback.
Replace ':nullAddress' string literals with NULL_ADDRESS_CONTEXT_VAR constant defined in conditions/const.ts, used in both AUTOMATICALLY_INJECTED_CONTEXT_PARAMS and RESERVED_CONTEXT_PARAMS.
Replace Buffer.from(...).toString('hex') with the existing toHexString
utility from @nucypher/shared for consistency with the rest of the
codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
authorizationType#677uint256#739getSigningCoordinatorChildto SigningCoordinatorAgent #749