Merged
Conversation
Backend:
- Wire ReportBuilder.build_report() to POST /reports/ (generates XML on create)
- Wire NCMECClient.full_submission() to POST /reports/{id}/submit
- Add GET /reports/{id}/summary for LE plain-text narrative
- Add GET /reports/ncmec/status health check
- Add POST /reports/{id}/retract proxy to NCMEC
- Add PATCH /reports/{id}/status for admin transitions
- Add GET /evidence/manifest/{session_id} with files + chain of custody
- Reporter identity configurable via env vars (not hardcoded)
- Voice transcripts included in XML and LE summary reports
- Remove submitted_by from ReportCreate (derived from auth context)
Dashboard:
- ReportDetailPage with Summary/XML/Evidence tabs
- Report rows clickable in ReportsPage
- Hooks for report detail, XML text, LE summary, retract
- API client getText() method for plain text endpoints
Tests:
- 12 ReportBuilder tests (XML generation, build_report, LE summary)
- 10 NCMECClient tests (endpoint wrappers, full_submission orchestration)
- 8 API report tests (DB persistence, status transitions, filtering)
- All 30 tests pass
Closes #27, #28, #29, #30, #31, #32, #33
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mark Phase 6 items complete, add reporter identity env vars to .env.example. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues Closed
Closes #27, #28, #29, #30, #31, #32, #33
Files Changed (16 files, +1664/-73)
Backend
server/nightshade/api/reports.py— 7 endpoints (create, submit, retract, status, xml, summary, ncmec/status)server/nightshade/api/evidence.py— manifest endpointserver/nightshade/config.py— reporter identity settingsserver/nightshade/reporting/report_builder.py— voice transcripts, config reporter, removed auto-commitserver/nightshade/evidence/constants.py— REPORT_RETRACTED, REPORT_STATUS_CHANGEDashboard
ReportDetailPage.tsx(new) — tabs for Summary/XML/Evidence, submit/retract actionsReportsPage.tsx— clickable rows, removed submitted_by from createhooks-evidence-reports.ts— useReport, useReportXml, useReportSummary, useRetractReportclient.ts— getText() for plain text endpointstypes.ts— SubmissionResult interfaceApp.tsx— /reports/:id routeTests
test_report_builder.py— 12 teststest_ncmec_client.py— 10 teststest_api/test_reports.py— 8 testsTest plan
pytest tests/test_reporting/ tests/test_api/test_reports.py -v— 30/30 passnpx tsc --noEmit— clean compileGenerated with Claude Code