fix(installer): skip re-download when release binary is already cached#36
Merged
DonPrus merged 3 commits intonullclaw:mainfrom May 5, 2026
Merged
Conversation
downloader.download() was called unconditionally on every install, even when the binary was already present in ~/.nullhub/bin/. This made every reinstall (e.g. updating provider config on an existing instance) pay the full network round-trip cost. Add the same existence check that stageLocalBinary already uses: open the target path; if it succeeds the binary is cached and the download is skipped entirely.
DonPrus
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloader.download()was called unconditionally on every install, even when the binary was already present in~/.nullhub/bin/stageLocalBinaryalready uses: attempt to open the target path; if it succeeds, the binary is cached and the download is skipped entirelyValidation
zig build test -Dbuild-ui=false --summary all— all tests pass, 0 leakszig fmt --check src/— cleanNotes
stageLocalBinary(src/installer/orchestrator.zig:754)~/.nullhub/bin/manually; a--forceflag could be added later if needed