fix(instances): stage native dev-local builds and report live status#38
Open
vernonstinebaker wants to merge 2 commits intonullclaw:mainfrom
Open
fix(instances): stage native dev-local builds and report live status#38vernonstinebaker wants to merge 2 commits intonullclaw:mainfrom
vernonstinebaker wants to merge 2 commits intonullclaw:mainfrom
Conversation
Contributor
Author
|
This is the focused follow-up for the managed NullClaw startup regression uncovered during validation of #34. Downstream context: NullClaw already contains the daemon nonblocking-accept fix, and the remaining issue for NullHub-managed instances was stale staged binaries. Related downstream PR context: nullclaw/nullclaw#878. |
Contributor
Author
|
This is the focused follow-up for the managed NullClaw startup regression uncovered during validation of #34. Downstream context: NullClaw Related downstream PR context: nullclaw/nullclaw#878. |
Managed starts were still picking stale local artifacts, and imported standalone instances could stay falsely running behind zombie PIDs on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-localbinaries at the canonical~/.nullhub/bin/<component>path and prefer localzig-out/bin/<component>-nativebuilds when availabledev-localbinaries before start so rebuilt local binaries are picked up without manual cache cleanupnullclaw/defaultstatus from its live gateway health instead of stale manager state, and ignore zombie PIDs on macOSWhy
dev-localbinary, not by generated configdefaultcould also remain falsely running because the old runtime state kept a zombie pid thatkill(pid, 0)still treated as alive on macOSValidation
zig buildzig build test -Dbuild-ui=false -Dembed-ui=falsehttp://127.0.0.1:19800withdefault,willy-nilly, andinstance-1all reporting healthydev-localstaging now matches the rebuilt local NullClaw binary by sha256Notes