Skip to content

build(test): make backend test entrypoint deterministic #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vernonstinebaker wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

build(test): make backend test entrypoint deterministic #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
npm --prefix ui run build

- name: Run unit tests
run: zig build test -Dbuild-ui=false --summary all 2>&1 | tee test-output.txt
run: zig build test -Dembed-ui=false -Dbuild-ui=false --summary all 2>&1 | tee test-output.txt

- name: Run E2E tests
if: runner.os == 'Linux'
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ Local access chain:

### Build Prerequisites

- `npm` is required for `zig build` and `zig build test` because the Svelte UI is
built and embedded into the binary during the Zig build.
- `npm` is required for `zig build` and for any build that embeds the Svelte UI.
- Backend-only tests can run without UI assets via `zig build test -Dembed-ui=false -Dbuild-ui=false`.

When these tools are missing, `nullhub` will try to install them automatically
via available system package managers (`apt`, `dnf`, `yum`, `pacman`, `zypper`,
Expand Down Expand Up @@ -124,7 +124,7 @@ optional `NULLTICKETS_TOKEN`.
Backend:

```bash
zig build test
zig build test -Dembed-ui=false -Dbuild-ui=false --summary all
```

Frontend:
Expand Down
2 changes: 1 addition & 1 deletion build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ fn ensureUiBuildReady(b: *std.Build) void {

fn ensureUiBuildExists() void {
if (!pathExists("ui/build")) {
std.debug.panic("embedded UI assets are missing; run `npm --prefix ui run build` or build with -Dbuild-ui=true", .{});
std.debug.panic("embedded UI assets are missing; run `npm --prefix ui run build`, build with -Dbuild-ui=true, or disable embedding with -Dembed-ui=false for backend-only tests", .{});
}
}

Expand Down