Skip to content

test(service): tighten systemctl status parsing #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vernonstinebaker wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

test(service): tighten systemctl status parsing #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/service.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,9 @@ fn captureStatusDetail(status: *const CaptureStatus) []const u8 {

fn isSystemctlMissingDetail(detail: []const u8) bool {
return std.ascii.indexOfIgnoreCase(detail, "command not found") != null or
std.ascii.indexOfIgnoreCase(detail, "not found") != null;
std.ascii.indexOfIgnoreCase(detail, "systemctl: not found") != null or
std.ascii.indexOfIgnoreCase(detail, "systemctl not found") != null or
std.ascii.indexOfIgnoreCase(detail, "systemctl: no such file or directory") != null;
}

fn isSystemdUnavailableDetail(detail: []const u8) bool {
Expand All @@ -408,3 +410,17 @@ test "preferredHomebrewShimPath resolves Linux Homebrew Cellar install" {
test "preferredHomebrewShimPath ignores non-Cellar paths" {
try std.testing.expect((try preferredHomebrewShimPath(std.testing.allocator, "/usr/local/bin/nullhub")) == null);
}

test "isSystemctlMissingDetail matches missing command output" {
try std.testing.expect(isSystemctlMissingDetail("systemctl: command not found"));
try std.testing.expect(isSystemctlMissingDetail("systemctl: not found"));
}

test "isSystemctlMissingDetail ignores missing unit output" {
try std.testing.expect(!isSystemctlMissingDetail("Unit nullhub.service could not be found."));
}

test "isSystemdUnavailableDetail matches user bus errors" {
try std.testing.expect(isSystemdUnavailableDetail("Failed to connect to bus: No medium found"));
try std.testing.expect(isSystemdUnavailableDetail("System has not been booted with systemd as init system (PID 1). Can't operate."));
}