Skip to content

Api detections #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nulledy wants to merge 19 commits into from
Closed

Api detections #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cabc250
Allow detections via API
nulledy Jan 20, 2026
8281dac
api-detections testing
nulledy Jan 21, 2026
19c837e
api-detection testing
nulledy Jan 21, 2026
932899c
api detections testing
nulledy Jan 21, 2026
1e04135
precapture offset is unnecessary for manual events
nulledy Jan 22, 2026
5240f47
api detections testing
nulledy Jan 23, 2026
85f8228
Merge pull request #1 from nulledy/v0.17.0-beta-2
nulledy Jan 23, 2026
562dfee
Debug API detections
nulledy Jan 25, 2026
38ddc48
api detection debugging
nulledy Jan 25, 2026
db60398
api detections debugging
nulledy Jan 25, 2026
e9c49e4
api detections debugging
nulledy Jan 25, 2026
0331fe9
api detections debugging
nulledy Jan 25, 2026
6e42da2
api detections debugging
nulledy Jan 25, 2026
bff1b4d
typo
nulledy Jan 25, 2026
e24a227
api-detections debugging
nulledy Jan 25, 2026
df96d1c
typo
nulledy Jan 25, 2026
ec5ee4f
debug cleanup
nulledy Jan 25, 2026
4986e24
api detections fixes
nulledy Jan 25, 2026
e095623
formatting and cleanup
nulledy Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions frigate/review/maintainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,12 @@ def update_existing_segment(
self.frame_manager.close(frame_name)
except FileNotFoundError:
return
# indefinite (manual) events should extend the segment until they end
if (
segment.camera in self.indefinite_events
and len(self.indefinite_events[segment.camera]) > 0
):
has_activity = True

if not has_activity:
if not segment.has_frame:
Expand Down Expand Up @@ -699,13 +705,25 @@ def run(self) -> None:
topic == DetectionTypeEnum.api
and self.config.cameras[camera].review.alerts.enabled
):
current_segment.severity = SeverityEnum.alert
if (
self.config.cameras[camera].review.detections.enabled
and manual_info["label"].split(": ")[0]
in self.config.cameras[camera].review.detections.labels
):
current_segment.last_detection_time = manual_info[
"end_time"
]
else:
current_segment.severity = SeverityEnum.alert
current_segment.last_alert_time = manual_info[
"end_time"
]
elif (
topic == DetectionTypeEnum.lpr
and self.config.cameras[camera].review.detections.enabled
):
current_segment.severity = SeverityEnum.detection
current_segment.last_alert_time = manual_info["end_time"]
current_segment.last_alert_time = manual_info["end_time"]
elif manual_info["state"] == ManualEventState.start:
self.indefinite_events[camera][manual_info["event_id"]] = (
manual_info["label"]
Expand All @@ -717,7 +735,16 @@ def run(self) -> None:
topic == DetectionTypeEnum.api
and self.config.cameras[camera].review.alerts.enabled
):
current_segment.severity = SeverityEnum.alert
if (
not self.config.cameras[
camera
].review.detections.enabled
or manual_info["label"].split(": ")[0]
not in self.config.cameras[
camera
].review.detections.labels
):
current_segment.severity = SeverityEnum.alert
elif (
topic == DetectionTypeEnum.lpr
and self.config.cameras[camera].review.detections.enabled
Expand Down Expand Up @@ -789,11 +816,21 @@ def run(self) -> None:
detections,
)
elif topic == DetectionTypeEnum.api:
if self.config.cameras[camera].review.alerts.enabled:
severity = None
if (
self.config.cameras[camera].review.detections.enabled
and manual_info["label"].split(": ")[0]
in self.config.cameras[camera].review.detections.labels
):
severity = SeverityEnum.detection
elif self.config.cameras[camera].review.alerts.enabled:
severity = SeverityEnum.alert

if severity:
self.active_review_segments[camera] = PendingReviewSegment(
camera,
frame_time,
SeverityEnum.alert,
severity,
{manual_info["event_id"]: manual_info["label"]},
{},
[],
Expand All @@ -820,7 +857,7 @@ def run(self) -> None:
].last_detection_time = manual_info["end_time"]
else:
logger.warning(
f"Manual event API has been called for {camera}, but alerts are disabled. This manual event will not appear as an alert."
f"Manual event API has been called for {camera}, but alerts and detections are disabled. This manual event will not appear as an alert or detection."
)
elif topic == DetectionTypeEnum.lpr:
if self.config.cameras[camera].review.detections.enabled:
Expand Down
3 changes: 1 addition & 2 deletions frigate/track/object_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,7 @@ def create_manual_event(self, payload: tuple) -> None:
"sub_label": sub_label,
"score": score,
"camera": camera_name,
"start_time": frame_time
- self.config.cameras[camera_name].record.event_pre_capture,
"start_time": frame_time,
"end_time": end_time,
"has_clip": self.config.cameras[camera_name].record.enabled
and include_recording,
Expand Down
Loading