Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Conversation

@trsigg
Copy link

@trsigg trsigg commented Sep 7, 2022

Method for creating a SparseBlockArray from a scipy.sparse object.

@trsigg trsigg requested a review from dlzou September 7, 2022 22:58
@dlzou
Copy link
Member

dlzou commented Sep 9, 2022

@trsigg Can you remove the asscalar fallback so tests pass? Should be the same as #563. Also, can you add a test case for the new method?

- add COO creation support in `ArrayApplication.array` and outward-facing `nps.from_coo` method
- add `test_from_coo`
- fix bug in `test_sparse_init` where expected results were for `int64` but arrays were created as `int32`
@dlzou dlzou merged commit e291cd0 into nums-project:graph-array-sparse Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants