Skip to content

[18.0][MIG] product_supplier_search: Migration to 18.0#692

Open
deeniiz wants to merge 10 commits into18.0from
18.0-mig-product_supplier_search
Open

[18.0][MIG] product_supplier_search: Migration to 18.0#692
deeniiz wants to merge 10 commits into18.0from
18.0-mig-product_supplier_search

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 15, 2025 15:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the product_supplier_search module from an earlier version to Odoo 18.0. The module enables searching products by supplier reference in selection fields and tree product views.

Key changes include:

  • Updated manifest with 18.0 version and 2025 copyright
  • Added complete module structure with views, models, and documentation
  • Implementation of enhanced product search functionality for supplier references

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
__manifest__.py Updated version to 18.0.1.0.0 and added 2025 copyright
models/product_product.py Core logic for enhanced product search by supplier codes
views/product_views.xml Search view extension for supplier product filtering
views/stock_picking_views.xml Stock picking form modifications for supplier context
Setup files Standard setuptools configuration for module packaging
Documentation README, translations, and static description files

@@ -0,0 +1 @@
Connector to get tracking info from ERTransit / Erhardt
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description 'Connector to get tracking info from ERTransit / Erhardt' does not match the actual functionality of this module, which is about searching products by supplier reference. The description should be updated to accurately reflect the module's purpose.

Suggested change
Connector to get tracking info from ERTransit / Erhardt
Module to search products by supplier reference.

Copilot uses AI. Check for mistakes.
!! source digest: sha256:ad67f7723a1da5cabbb99bf6dd5ad8a2b1e004c0195ae212f4684749cfd719de
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/NuoBiT/odoo-addons/tree/18.0/product_supplier_search"><img alt="NuoBiT/odoo-addons" src="https://img.shields.io/badge/github-NuoBiT%2Fodoo--addons-lightgray.png?logo=github" /></a></p>
<p>Connector to get tracking info from ERTransit / Erhardt</p>
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description in the HTML documentation is inconsistent with the module's actual functionality. This should describe product supplier search functionality instead of ERTransit/Erhardt tracking.

Suggested change
<p>Connector to get tracking info from ERTransit / Erhardt</p>
<p>Provides advanced search capabilities for product suppliers within Odoo.</p>

Copilot uses AI. Check for mistakes.
Comment thread product_supplier_search/README.rst Outdated

|badge1| |badge2| |badge3|

Connector to get tracking info from ERTransit / Erhardt
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README description does not match the module's purpose. It should describe the product supplier search functionality rather than ERTransit/Erhardt tracking information.

Suggested change
Connector to get tracking info from ERTransit / Erhardt
Provides advanced search capabilities for finding product suppliers within Odoo.

Copilot uses AI. Check for mistakes.
@deeniiz deeniiz force-pushed the 18.0-mig-product_supplier_search branch from 439b25a to ff79932 Compare September 15, 2025 15:58
@deeniiz deeniiz requested a review from eantones September 15, 2025 16:00
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Feb 22, 2026
@eantones eantones added no stale and removed stale labels Feb 23, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-product_supplier_search branch from ff79932 to 7aa4475 Compare March 12, 2026 09:36
@deeniiz deeniiz force-pushed the 18.0-mig-product_supplier_search branch from 7aa4475 to e309902 Compare March 12, 2026 09:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
product_supplier_search/models/product_product.py 21.73% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #692   +/-   ##
=======================================
  Coverage        ?   28.00%           
=======================================
  Files           ?        3           
  Lines           ?       25           
  Branches        ?        7           
=======================================
  Hits            ?        7           
  Misses          ?       18           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants