[18.0][MIG] project_legal_management: Migration to 18.0#693
[18.0][MIG] project_legal_management: Migration to 18.0#693
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project_legal_management module from an earlier Odoo version to version 18.0. The migration introduces a new module that extends the project module with legal management functionality, allowing users to track legal cases, probabilities, resolutions, and related information within projects.
Key Changes:
- Complete module migration to Odoo 18.0 with updated version numbering
- Addition of legal management fields to project model (date, employees, expedient number, issues, resolution, amount, probability)
- Creation of three new models:
lm.issue,lm.probability, andlm.resolutionwith hierarchical tree structure support
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Module manifest updated to version 18.0.1.0.0 with dependencies and data files |
models/*.py |
New model definitions for legal management entities and project extensions |
views/*.xml |
View definitions for forms, trees, and menu items for legal management functionality |
security/ir.model.access.csv |
Access rights configuration for the new models |
i18n/es.po |
Spanish translations for the module |
setup/ |
Setup configuration files for module installation |
| if operator not in operation_mapping: | ||
| raise UserError(_("Operator %s not implemented") % operator) | ||
| node_ids = [] | ||
| for node in self.env[self._name].search([]): |
There was a problem hiding this comment.
This method searches all records without any domain filter, which could be inefficient for large datasets. Consider adding pagination or limiting the search scope to improve performance.
| for node in self.env[self._name].search([]): | |
| # Try to filter at the database level using the operator and value | |
| # For 'like' and 'ilike', we can use them directly in the domain | |
| domain_operator = operator if operator in ["like", "ilike", "=", "!="] else "ilike" | |
| # Limit the number of records to avoid performance issues | |
| candidate_nodes = self.env[self._name].search([("name", domain_operator, value)], limit=1000) | |
| for node in candidate_nodes: |
fa22279 to
ebbe951
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
ebbe951 to
d73a619
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #693 +/- ##
=======================================
Coverage ? 72.94%
=======================================
Files ? 7
Lines ? 85
Branches ? 8
=======================================
Hits ? 62
Misses ? 23
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.