Skip to content

[18.0][MIG] project_legal_management: Migration to 18.0#693

Open
deeniiz wants to merge 12 commits into18.0from
18.0-mig-project_legal_management
Open

[18.0][MIG] project_legal_management: Migration to 18.0#693
deeniiz wants to merge 12 commits into18.0from
18.0-mig-project_legal_management

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 15, 2025 16:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project_legal_management module from an earlier Odoo version to version 18.0. The migration introduces a new module that extends the project module with legal management functionality, allowing users to track legal cases, probabilities, resolutions, and related information within projects.

Key Changes:

  • Complete module migration to Odoo 18.0 with updated version numbering
  • Addition of legal management fields to project model (date, employees, expedient number, issues, resolution, amount, probability)
  • Creation of three new models: lm.issue, lm.probability, and lm.resolution with hierarchical tree structure support

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
__manifest__.py Module manifest updated to version 18.0.1.0.0 with dependencies and data files
models/*.py New model definitions for legal management entities and project extensions
views/*.xml View definitions for forms, trees, and menu items for legal management functionality
security/ir.model.access.csv Access rights configuration for the new models
i18n/es.po Spanish translations for the module
setup/ Setup configuration files for module installation

Comment thread project_legal_management/__manifest__.py
if operator not in operation_mapping:
raise UserError(_("Operator %s not implemented") % operator)
node_ids = []
for node in self.env[self._name].search([]):
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method searches all records without any domain filter, which could be inefficient for large datasets. Consider adding pagination or limiting the search scope to improve performance.

Suggested change
for node in self.env[self._name].search([]):
# Try to filter at the database level using the operator and value
# For 'like' and 'ilike', we can use them directly in the domain
domain_operator = operator if operator in ["like", "ilike", "=", "!="] else "ilike"
# Limit the number of records to avoid performance issues
candidate_nodes = self.env[self._name].search([("name", domain_operator, value)], limit=1000)
for node in candidate_nodes:

Copilot uses AI. Check for mistakes.
@deeniiz deeniiz force-pushed the 18.0-mig-project_legal_management branch 2 times, most recently from fa22279 to ebbe951 Compare September 16, 2025 07:27
@deeniiz deeniiz requested a review from eantones September 16, 2025 07:31
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Feb 22, 2026
@eantones eantones added no stale and removed stale labels Feb 23, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-project_legal_management branch from ebbe951 to d73a619 Compare March 12, 2026 09:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 72.94118% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
project_legal_management/models/tree.py 37.83% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #693   +/-   ##
=======================================
  Coverage        ?   72.94%           
=======================================
  Files           ?        7           
  Lines           ?       85           
  Branches        ?        8           
=======================================
  Hits            ?       62           
  Misses          ?       23           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants