[18.0][MIG] account_move_accrual_entry: Migration to 18.0#697
Open
[18.0][MIG] account_move_accrual_entry: Migration to 18.0#697
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the account_move_accrual_entry module from an earlier version to Odoo 18.0. The module creates journal entries at accrual dates and adds smart buttons to invoices for accessing them.
Key changes:
- Complete module migration to 18.0 with updated manifest version
- Implementation of accrual date functionality for invoices with automatic journal entry creation
- Configuration settings for accrual parameters in invoice settings
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Updated version to 18.0.1.0.0 and module metadata |
models/account_move.py |
Core accrual logic with date validation and journal entry creation |
models/account_move_line.py |
Line-level accrual account handling and onchange methods |
models/res_company.py |
Company-level accrual configuration fields |
models/res_config_settings.py |
Settings interface for accrual parameters |
views/account_move_views.xml |
Invoice form view extensions for accrual functionality |
views/res_config_settings_views.xml |
Configuration settings view for accrual parameters |
| Various documentation files | README, translations, and description files |
| if rec.move_type in ("out_invoice", "out_refund") and rec.accrual_date: | ||
| asset_lines = rec.invoice_line_ids.filtered( | ||
| lambda x: x.accrual_account_id.account_type | ||
| == self.company_accrual_account_asset_type_id |
There was a problem hiding this comment.
The comparison uses self.company_accrual_account_asset_type_id which is an account record, but it's being compared to account_type which is a string field. This should be self.company_accrual_account_asset_type_id.account_type.
Suggested change
| == self.company_accrual_account_asset_type_id | |
| == self.company_accrual_account_asset_type_id.account_type |
…ournal entry Adds smart-button in invoice to access it Create accrual_account_id and accrual_asset_account_type in invoice settings
… notes and sections
deeniiz
force-pushed
the
18.0-mig-account_move_accrual_entry
branch
from
7fc9249 to
a78b8a4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #697 +/- ##
=======================================
Coverage ? 42.24%
=======================================
Files ? 6
Lines ? 116
Branches ? 25
=======================================
Hits ? 49
Misses ? 67
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.