Skip to content

[18.0][MIG] account_financial_report_multi_company: Migration to 18.0#703

Open
deeniiz wants to merge 5 commits into18.0from
18.0-mig-account_financial_report_multi_company
Open

[18.0][MIG] account_financial_report_multi_company: Migration to 18.0#703
deeniiz wants to merge 5 commits into18.0from
18.0-mig-account_financial_report_multi_company

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 18, 2025 11:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the account_financial_report_multi_company module from a previous version to Odoo 18.0, enabling multi-company financial report generation functionality.

Key changes:

  • Complete module structure creation with all necessary files for the migration
  • Implementation of multi-company support for trial balance reports
  • Addition of company selection wizard and report templates

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
__manifest__.py Module manifest defining dependencies and data files
__init__.py Module initialization importing wizards and reports
wizards/trial_balance_wizard.py Wizard extending trial balance with multi-company field
wizards/trial_balance_wizard_views.xml UI view modifications for company selection
report/trial_balance.py Core report logic for multi-company trial balance
report/abstract_report.py Base report functionality with company data
report/trial_balance_xlsx.py Excel export with company column
report/templates/trial_balance.xml Report template with company display
Documentation and translation files Supporting files for module description and localization

Comment thread account_financial_report_multi_company/__manifest__.py Outdated
relation="trial_balance_report_wizard_company_rel",
column1="trial_balance_report_wizard_id",
column2="company_id",
default=lambda self: self.env.company.ids,
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value uses self.env.company.ids but self.env.company is a single record, so .ids returns a list with one ID. This should be self.env.company (without .ids) since the field expects a recordset for Many2many default values.

Suggested change
default=lambda self: self.env.company.ids,
default=lambda self: self.env.company,

Copilot uses AI. Check for mistakes.
Comment thread account_financial_report_multi_company/report/abstract_report.py
Comment thread account_financial_report_multi_company/report/trial_balance.py
@deeniiz deeniiz force-pushed the 18.0-mig-account_financial_report_multi_company branch from 1eca225 to 6891ca6 Compare September 18, 2025 11:13
@deeniiz deeniiz requested a review from eantones September 18, 2025 12:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Mar 1, 2026
@eantones eantones added no stale and removed stale labels Mar 1, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-account_financial_report_multi_company branch from 6891ca6 to 874e201 Compare March 12, 2026 10:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 48.33333% with 31 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ncial_report_multi_company/report/trial_balance.py 27.58% 21 Missing ⚠️
...ial_report_multi_company/report/abstract_report.py 44.44% 5 Missing ⚠️
...port_multi_company/wizards/trial_balance_wizard.py 72.72% 3 Missing ⚠️
..._report_multi_company/report/trial_balance_xlsx.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #703   +/-   ##
=======================================
  Coverage        ?   48.33%           
=======================================
  Files           ?        7           
  Lines           ?       60           
  Branches        ?        5           
=======================================
  Hits            ?       29           
  Misses          ?       31           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants