[18.0][MIG] account_invoice_report_service: Migration to 18.0

[deeniiz]

No description provided.

[Copilot]

Pull Request Overview

This PR migrates the account_invoice_report_service module from a previous version to Odoo 18.0. The migration introduces custom invoice and delivery PDF reports with service-specific functionality.

Key changes:

• Migration to version 18.0 with updated tax totals handling
• Implementation of custom invoice and delivery report templates
• Addition of timezone-aware date computations for service orders

Reviewed Changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test-requirements.txt	Adds dependency on external sale_order_service module from Git
account_invoice_report_service/manifest.py	Updates module version to 18.0.1.0.0 and defines module structure
account_invoice_report_service/views/report_invoice_service.xml	Implements service invoice report template with patient and service data sections
account_invoice_report_service/views/report_invoice_delivery.xml	Implements delivery invoice report template with item details
account_invoice_report_service/models/account_invoice.py	Adds invoice grouping logic and line processing methods
account_invoice_report_service/models/sale_order.py	Adds timezone-aware date computation for orders

[Copilot]

The tax totals structure has changed in Odoo 18.0. The 'groups_by_subtotal' key should be 'subtotals' to match the new tax totals format.

[Copilot]

The tax groups structure should use 'groups_by_subtotal' instead of 'subtotals' to access tax group data. This appears to be inconsistent with the service report template.

Suggested change

	t-value="tax_totals['subtotals'].get('Untaxed Amount', [])"
	t-value="tax_totals['groups_by_subtotal'].get('Untaxed Amount', [])"

[Copilot]

This condition checks for 'groups_by_subtotal' but should check for 'subtotals' to be consistent with Odoo 18.0 tax totals structure.

Suggested change

	t-if="not (tax_totals and tax_totals['groups_by_subtotal'])"
	t-if="not (tax_totals and tax_totals['subtotals'])"

[Copilot]

This condition should check for 'groups_by_subtotal' to be consistent with the tax groups access pattern used elsewhere in the codebase.

Suggested change

	t-if="not (tax_totals and tax_totals['subtotals'])"
	t-if="not (tax_totals and tax_totals['subtotals'] and tax_totals['groups_by_subtotal'])"

[codecov]

Codecov Report

❌ Patch coverage is 36.29630% with 86 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ount_invoice_report_service/models/account_move.py	18.75%	65 Missing ⚠️
...t_invoice_report_service/report/account_invoice.py	44.00%	14 Missing ⚠️
...ccount_invoice_report_service/models/sale_order.py	53.33%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             18.0     #705   +/-   ##
=======================================
  Coverage        ?   36.29%           
=======================================
  Files           ?        8           
  Lines           ?      135           
  Branches        ?       23           
=======================================
  Hits            ?       49           
  Misses          ?       86           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.